[nasa/nos3#577] CSS-System-Tests

[dacarter22]

Added System Tests for CSS. Steps to test below:

1. Pull nos3#577-css-system-tests
2. build with cfs and cosmos
3. Launch command telemetry server and test runner.
4. Wait for 20 seconds and change to generic_css test suite
5. click start
6. verify tests pass

This PR closes issue #577

Submodules to be merged into dev:

• [nasa/nos3#577] css system tests nasa-itc/generic_css#12

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.88%. Comparing base (1b52bab) to head (13d11d0).
Report is 114 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #598      +/-   ##
==========================================
+ Coverage   72.77%   72.88%   +0.11%     
==========================================
  Files         744      747       +3     
  Lines       91191    91899     +708     
  Branches     6923     6975      +52     
==========================================
+ Hits        66362    66981     +619     
- Misses      24829    24918      +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Isgaroth-the-Green]

The tests all appear to run largely as they should; I did have one fail the first time through, but that was merely due to one of the numbers not getting low enough quite in time, and running it twice more, every test passed.

[dacarter22]

Increased wait time from 30 to 60 seconds

[kevincbruce]

Everything looks ok. When running the test, had an error on the data loop for the AST prep I believe. One of the Voltages was pretty far off (I believe around 400). Though in all other cases, it all passed, so I'm not sure if this is an odd discrepancy, or some oversight. May require some more review.

Update: On subsequent runs, seems to work fine, so leaning towards it being an edge case from running too close to startup or some other factor. Though still, if variation is greater than 5, may be worth looking at increasing the margin and decreasing the wait time.

[Isgaroth-the-Green]

Twice when I have run it, I have gotten a similar (large) error with both the GENERIC_CSS_DATA_TLM_RAW_CSS_3 and GENERIC_CSS_DATA_TLM_RAW_0 (the latter wrong by a value of 800, and the former wrong by 500 or so). They are always wrong together, and when I run a second time the error usually goes away.

[dacarter22]

Let me double check with John, I was getting a similar issue but it seems to happen randomly, I'll see if there's a way to restrict the tests to only fire under sunsafe mode

[dacarter22]

Okay, I think its a problem of running the tests too soon after launch, I was able to get them all to execute correctly on the first try after waiting 20-30 seconds after I launched telemetry server

[dacarter22]

[kevincbruce]

That's more or less what I was seeing too, was the first run would have issues, but once I waited a bit it would run fine. May be a consequence of not having an isvalid value for CSS, and thus not knowing if it is in sun enough to get an accurate reading (or whatever validity is checking for, I'm not 100%)

[jlucas9]

I have some updates to the entire PR. Can walk through them tomorrow if desired.

[jlucas9]

I approve after my commit modifications.

[zlynch2]

Instead of waiting 20 seconds you can wait for mode 2 sun point which I think is a tlm point from adcs.

[kevincbruce]

Ran new version a few times in a row. Seems to work well, so approval maintained.

[zlynch2]

Ran new push, seems to work. Approving

[Isgaroth-the-Green]

It looks good; I am no longer having the same issues as before.