[nasa/nos3#716] fprime components to nos3 components#718
Merged
Conversation
KushalP17
requested review from
a team,
Donnie-Ice,
Isgaroth-the-Green,
dacarter22,
dccutrig,
jlucas9,
kevincbruce,
msuder,
rjbrown2,
szemerick and
zlynch2
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #718 +/- ##
==========================================
+ Coverage 72.88% 73.95% +1.06%
==========================================
Files 748 761 +13
Lines 92138 93581 +1443
Branches 6976 6986 +10
==========================================
+ Hits 67157 69207 +2050
+ Misses 24981 24374 -607 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kevincbruce
approved these changes
Jun 2, 2025
Contributor
kevincbruce
left a comment
kevincbruce
left a comment
There was a problem hiding this comment.
Pulled, built, checked most/all commands from across all apps, and saw outputs all come through, so looks good!
dacarter22
approved these changes
Jun 3, 2025
Contributor
dacarter22
left a comment
dacarter22
left a comment
There was a problem hiding this comment.
Ran Request Data/HK commands with each component and confirmed data came down. Good job!
zlynch2
approved these changes
Jun 3, 2025
Collaborator
zlynch2
left a comment
zlynch2
left a comment
There was a problem hiding this comment.
new architecture builds/works both fprime/default nos operations. Arducam pic still comes down in fprime-nos3 for reference. Approving.
jlucas9
approved these changes
Jun 4, 2025
vedantt21
pushed a commit
to vedantt21/nos3-mantle
that referenced
this pull request
Feb 18, 2026
…omponents [nasa#716] fprime components to nos3 components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved all components currently implemented in fprime into their larger nos3 components
Implemented getting quaternion data for star tracker component in fprime
Delete some extraneous fprime src files within components
How to test:
Submodules to be merged:
fprime-nos3 - 716-fprime_components_to_nos3_components
generic_radio - 716-fprime_components_to_nos3_components
generic_torquer - 716-fprime_components_to_nos3_components
generic_thruster - 716-fprime_components_to_nos3_components
generic_star_tracker - 716-fprime_components_to_nos3_components
generic_reaction_wheel - 716-fprime_components_to_nos3_components
generic_magnetometer - 716-fprime_components_to_nos3_components
generic_imu - 716-fprime_components_to_nos3_components
generic_fss - 716-fprime_components_to_nos3_components
generic_eps - 716-fprime_components_to_nos3_components
generic_css - 716-fprime_components_to_nos3_components
arducam - 716-fprime_components_to_nos3_components
Closes #713 (Added request data command for star tracker)
Closes #716