Skip to content

[nasa/nos3#740] fprime adcs#757

Merged
zlynch2 merged 62 commits intodevfrom
nos3#740-fprime_adcs
Aug 20, 2025
Merged

[nasa/nos3#740] fprime adcs#757
zlynch2 merged 62 commits intodevfrom
nos3#740-fprime_adcs

Conversation

@KushalP17
Copy link
Contributor

Added most ADCS functionality in Fprime (besides the extensive ADCS telemetry packets)
Implemented Data & Control Loops @ 5Hz
Added periodic updating of component tlm @ 1Hz
Added Custom Ports in Fprime
Added additional RateGroup @ 5Hz, Changed Block Driver to be 10x faster
Changed Fprime Launch Script for more consistent deployment
Refactored ADCS in Fprime & cFS to utilize shared folder
Added an additional Proportional controller to RW in Bdot mode to kill momentum (not just torque)

How to Test:

  1. Clone nos3#740-fprime_adcs
  2. Switch to fprime gsw/fsw, & sc-fprime-config.xml in nos3 cfg
  3. Run various adcs commands
  4. Ensure device counters for fss, css, imu, mag, rw, star tracker, & torquer are all increasing steadily
  5. Test Sunsafe Mode (There is slightly weird behavior where it gets stuck, switch between another mode and sunsafe to break out of this behavior)
  6. Test Bdot Mode & Make sure RW momentum is ~0 (below 0.0001)

Submodules to be merged:
generic_adcs - 740-fprime_adcs
generic_css - 740-fprime-adcs
generic_eps - 740-fprime_adcs
generic_fss - 740-fprime-adcs
generic_imu - 740-fprime-adcs
generic_magnetometer - 740-fprime-adcs
generic_reaction_wheel - 740-fprime-adcs
generic_star_tracker - 740-fprime-adcs
generic_torquer - 740-fprime_adcs
fprime - 740-fprime-adcs
fprime-nos3 - 740-fprime_adcs

Closes #740
Closes #749
Closes #736

KushalP17 added 30 commits June 12, 2025 17:19
@KushalP17 KushalP17 self-assigned this Jul 9, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.64%. Comparing base (0133d63) to head (62a0a4f).
⚠️ Report is 76 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #757   +/-   ##
=======================================
  Coverage   73.63%   73.64%           
=======================================
  Files         761      761           
  Lines       93985    93972   -13     
  Branches     7063     7064    +1     
=======================================
- Hits        69206    69203    -3     
+ Misses      24779    24769   -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KushalP17 KushalP17 changed the title [nasa/nos3#740] fprime adcs [WIP] [nasa/nos3#740] fprime adcs Jul 11, 2025
@KushalP17
Copy link
Contributor Author

Merging with dev broke it, thanks for letting me know @Donnie-Ice

@KushalP17 KushalP17 changed the title [WIP] [nasa/nos3#740] fprime adcs [nasa/nos3#740] fprime adcs Jul 22, 2025
Copy link
Contributor

@kevincbruce kevincbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears to sunpoint as expected. Was having some issues with inertial, but that could be from me not knowing what state we are launching into exactly

Copy link

@Will-Matheny Will-Matheny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked on older JSTAR laptop with shared and without did not see any increase in torquer it stayed at 0, but everything else seemed to work.

Copy link
Contributor

@Isgaroth-the-Green Isgaroth-the-Green left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through the list of (testing) instructions, and everything worked as intended.

zlynch2 added 11 commits August 20, 2025 11:34
# Conflicts:
#	components/generic_adcs
#	components/generic_css
#	components/generic_eps
#	components/generic_fss
#	components/generic_imu
#	components/generic_mag
#	components/generic_radio
#	components/generic_reaction_wheel
#	components/generic_star_tracker
#	components/generic_thruster
#	components/generic_torquer
#	fsw/apps/cf
#	fsw/apps/ci
#	fsw/apps/io_lib
#	fsw/apps/sc
#	fsw/fprime/fprime-nos3
#	scripts/fsw/fsw_fprime_launch.sh
@zlynch2 zlynch2 merged commit 2d41253 into dev Aug 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

Comments