Report if the temp file couldn't be deleted#17
Report if the temp file couldn't be deleted#17szh wants to merge 1 commit intonatefinch:masterfrom szh:result-struct
Conversation
|
As I've been polishing this code I could not resist taking this into account, hence my attempt at it using option funcs above, based on earlier work in #20. |
|
Was actually expecting a suggestion or at least a comment with regard to testing, as that's an interesting aspect. |
|
We ended up implementing this internally so I'm not going to be able to dedicate time to finishing up the implementation here. If you want to close the PR that's fine with me. |
In security sensitive use cases, it would be helpful to allow the caller to know if deleting the temp file failed, so it could retry after a delay, or at least log the failure.
My main concern is how to test this functionality.