Add support for changing the default file mode using options pattern (fixes natefinch/atomic#7)#18
Open
sdassow wants to merge 6 commits intonatefinch:masterfrom
Open
Add support for changing the default file mode using options pattern (fixes natefinch/atomic#7)#18sdassow wants to merge 6 commits intonatefinch:masterfrom
sdassow wants to merge 6 commits intonatefinch:masterfrom
Conversation
Author
|
Now after renaming the option from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Something about #12 didn't feel right or clean enough, so here's an alternative approach using the options pattern instead.
While this increases complexity a bit, it comes with the benefit of a clean interface in case of further options.