[ENH] Annotations in dss_line_iter plots and specification of a saving path#89
[ENH] Annotations in dss_line_iter plots and specification of a saving path#89nbara merged 7 commits intonbara:masterfrom
Conversation
|
Tip: in your base directory, run |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the dss_line_iter plotting annotations and refactors how output figures are saved, as well as updates tests and examples to match the new API.
- Improved plot labels, titles, and added a legend for clarity.
- Removed the
prefixparameter; introduceddirnameandextensionfor saving control. - Updated tests and example script to use the new
dirnameargument.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| tests/test_dss.py | Switched from prefix to dirname, adjusted fline, and updated test calls. |
| meegkit/dss.py | Modified dss_line_iter signature, plotting annotations, and save logic. |
| examples/example_dss_line.py | Reordered keyword args and added show=True; needs updating for dirname. |
Comments suppressed due to low confidence (1)
tests/test_dss.py:152
- Add a test case to verify that files are saved correctly with the specified
extensionand naming pattern whendirnameis provided.
out, _ = dss.dss_line_iter(x, fline + 1, sr, show=True, dirname=tmpdir)
Ok thanks ! Sorry I don't contribute a lot |
|
No worries at all, happy to help! |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #89 +/- ##
==========================================
+ Coverage 82.87% 82.97% +0.10%
==========================================
Files 25 25
Lines 2815 2826 +11
==========================================
+ Hits 2333 2345 +12
+ Misses 482 481 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey @nbara, Elias |
|
Thanks @eliasbenyahia ! |
Modified annotations of dss_line_iter plots when show=True:
In dss_line_iter function: