Add asset bootstrap script and base64 encoded assets#2
Conversation
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Line 2 in 4fdfe3d
[P1] Stop ignoring entire app module
.gitignore currently ignores the root app/ directory to avoid committing generated assets, but that rule also hides every source file for the Android module (Gradle scripts, manifests, Kotlin/Java, etc.) from version control. Once real app code is added or modified, git status will never surface the changes, making it impossible to commit or review the core application. Limit the ignore pattern to the generated asset subdirectories (e.g. app/src/main/assets and app/src/main/res/drawable) so that code remains tracked while binaries stay out of Git.
[P1] Provide real base64 for rotor model
The file assets/rotor_v1.tflite.b64 decodes to the ASCII string "rotor model placeholder" (22 bytes) rather than a TensorFlow Lite binary. After running bootstrap_assets.py, the generated rotor_v1.tflite will not be a valid model, so any code that tries to load it will immediately fail at runtime. Replace this placeholder with the actual base64 of the TFLite model or document that the user must supply it, otherwise the bootstrapping step cannot produce working assets.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
Summary
Testing
python3 scripts/bootstrap_assets.pypython3 -m py_compile scripts/bootstrap_assets.pyhttps://chatgpt.com/codex/tasks/task_e_68c32f6e8bf88328b3e60f2a83f4bbd1