Skip to content

Add NEARBY_WIFI_DEVICES permission#5

Open
nbschultz97 wants to merge 9 commits intomainfrom
codex/add-nearby-wifi-devices-permission
Open

Add NEARBY_WIFI_DEVICES permission#5
nbschultz97 wants to merge 9 commits intomainfrom
codex/add-nearby-wifi-devices-permission

Conversation

@nbschultz97
Copy link
Owner

Summary

  • Add NEARBY_WIFI_DEVICES permission to manifest
  • Include Manifest.permission.NEARBY_WIFI_DEVICES in runtime checks
  • Ignore generated assets under app/src/main/assets and app/src/main/res/drawable

Testing

  • python3 scripts/bootstrap_assets.py
  • ./gradlew test (fails: No such file or directory)

https://chatgpt.com/codex/tasks/task_e_68c331bae46c8328990a1571cc5a6926

@nbschultz97
Copy link
Owner Author

@codex fix comments

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

@chatgpt-codex-connector
Copy link

Summary

Testing

  • python3 scripts/bootstrap_assets.py
  • ⚠️ ./gradlew test (No such file or directory)

View task →

@nbschultz97
Copy link
Owner Author

@codex should I close this PR if the comment fixed it?

@chatgpt-codex-connector
Copy link

You don’t need to close the PR. Since the latest comment addressed the reviewer’s feedback, you can keep the PR open and wait for final review or merge.

View task →

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant