Skip to content

Use coroutine to fetch flight data off main thread #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nbschultz97 merged 1 commit into from
Sep 12, 2025
Merged

Use coroutine to fetch flight data off main thread #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion app/src/main/java/com/example/dronedetect/DroneSignalDetector.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,34 @@ import android.content.Intent
import android.net.wifi.WifiManager
import android.os.Handler
import android.os.Looper
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.SupervisorJob
import kotlinx.coroutines.cancel
import kotlinx.coroutines.launch
import kotlinx.coroutines.withContext

class DroneSignalDetector(private val context: Context) {
private val handler = Handler(Looper.getMainLooper())
private val wifiManager = context.applicationContext.getSystemService(Context.WIFI_SERVICE) as WifiManager
private val receiver = WifiScanReceiver()
private val scope = CoroutineScope(SupervisorJob() + Dispatchers.IO)

fun startScan() {
// TODO: implement scanning logic
scope.launch {
fetchFlightData()
// TODO: implement scanning logic
}
}

suspend fun fetchFlightData() = withContext(Dispatchers.IO) {
// TODO: implement fetching flight data
}

fun stopScan() {
handler.removeCallbacksAndMessages(null)
context.unregisterReceiver(receiver)
scope.cancel()
Comment on lines 33 to +36
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Recreate CoroutineScope after cancellation

Because the scope is a single CoroutineScope(SupervisorJob() + Dispatchers.IO) stored as a val, calling stopScan() cancels that scope permanently. Any subsequent call to startScan() will try to scope.launch { … } on a cancelled scope and the coroutine will immediately cancel, so fetchFlightData() never runs after the first stop. If this detector is started and stopped repeatedly during the app lifecycle, scanning cannot resume. Consider creating a new scope when starting or cancelling only the active job instead of the whole scope.

Useful? React with 👍 / 👎.

}
}

Expand Down
Loading