test: improve test coverage #28
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add comprehensive tests for previously uncovered code paths:
Wrapper tests:
consulClientwrapper methods (Agent, Catalog, Health, Session, KV)commandExecutor.CommandContextAsync execution tests:
updateServiceTagscommand execution (ExecOnPromote/ExecOnDemote)Edge case tests:
Runwith small TTL (< 2s interval branch)Runelection error handling in ticker loopupdateLeadershipStatuserror return pathNewviper unmarshal errorNewdefault values for LockDelay/TTL/NameCoverage
Local measurements:
New: 85.7% → 96.4%Run: 69.2% → 76.9%updateLeadershipStatus: 80% → 100%consulClientwrappers: 0% → 100%commandExecutor.CommandContext: 0% → 100%Note:
HealthWrapper.Checksremains at 0% - it wraps*api.Health(concrete type) and requires a real Consul instance (covered by integration tests).Test plan
🤖 Generated with Claude Code