Skip to content

implement LPP-33: return slot supervisors#34

Merged
RiedleroD merged 3 commits intomainfrom
lpp-33-return-slot-supervisors
Dec 17, 2024
Merged

implement LPP-33: return slot supervisors#34
RiedleroD merged 3 commits intomainfrom
lpp-33-return-slot-supervisors

Conversation

@RiedleroD
Copy link
Contributor

TODO: test on testserver

@RiedleroD RiedleroD self-assigned this Dec 14, 2024
@mcquenji
Copy link
Contributor

{
  "exception": "TypeError",
  "message": "Argument 2 passed to local_lbplanner\\helpers\\slot_helper::filter_slots_for_user() must be an instance of local_lbplanner\\helpers\\mixed, instance of stdClass given, called in \\/bitnami\\/moodle\\/local\\/lbplanner\\/services\\/slots\\/get_my_slots.php on line 51"
}

@RiedleroD RiedleroD requested a review from mcquenji December 17, 2024 17:00
Copy link
Contributor

@mcquenji mcquenji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RiedleroD RiedleroD merged commit 141d0db into main Dec 17, 2024
2 checks passed
@RiedleroD RiedleroD deleted the lpp-33-return-slot-supervisors branch December 17, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants