Skip to content

fix: allow null for vintage in get_all_users #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RiedleroD merged 3 commits into from
Dec 17, 2024
Merged

fix: allow null for vintage in get_all_users #38

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d24e735
fix: allow null for vintage in get_all_users
RiedleroD Dec 16, 2024
c1a744f
fixed: type in get_all_users function
RiedleroD Dec 17, 2024
efdf67a
fix: type in docstring of get_all_users
RiedleroD Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lbplanner/services/user/get_all_users.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,18 +42,18 @@ class user_get_all_users extends external_api {
*/
public static function get_all_users_parameters(): external_function_parameters {
return new external_function_parameters([
'vintage' => new external_value(PARAM_TEXT, 'The vintage to filter the users by', VALUE_DEFAULT, null),
'vintage' => new external_value(PARAM_TEXT, 'The vintage to filter the users by', VALUE_DEFAULT, null, NULL_ALLOWED),
]);
}

/**
* Gives back all users registered by the lbplanner app.
* @param string $vintage (optional) gives back all users with the given vintage
* @param ?string $vintage (optional) gives back all users with the given vintage
* @throws moodle_exception
* @throws dml_exception
* @throws invalid_parameter_exception
*/
public static function get_all_users(string $vintage): array {
public static function get_all_users(?string $vintage): array {
global $DB, $USER;

self::validate_parameters(self::get_all_users_parameters(), ['vintage' => $vintage]);
Expand Down
Loading