Skip to content

fix set_deadline #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RiedleroD merged 3 commits into from
Dec 17, 2024
Merged

fix set_deadline #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e249fd
fix: no using ValueError! bad Riedler :bonk:
RiedleroD Dec 17, 2024
a4f7b4f
fix: cast to int
RiedleroD Dec 17, 2024
86b7353
fix: set_deadline
RiedleroD Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lbplanner/classes/helpers/plan_helper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ public static function get_access_type(int $userid, int $planid): int {
if ($field === false) {
return PLAN_ACCESS_TYPE::NONE;
} else {
return PLAN_ACCESS_TYPE::from($field);
return PLAN_ACCESS_TYPE::from((int)$field);
}
}

Expand Down
5 changes: 2 additions & 3 deletions lbplanner/classes/polyfill/Enum.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
namespace local_lbplanner\polyfill;

use ReflectionClass;
use ValueError;
use local_lbplanner\polyfill\EnumCase;

/**
Expand All @@ -38,7 +37,7 @@ class Enum {
* @param mixed $value the value to be matched
* @param bool $try whether to return null (true) or throw an error (false) if not found
* @return ?EnumCase the matching enum case or null if not found and $try==true
* @throws ValueError if not found and $try==false
* @throws \moodle_exception if not found and $try==false
*/
private static function find(mixed $value, bool $try): ?EnumCase {
foreach (static::cases() as $case) {
Expand All @@ -50,7 +49,7 @@ private static function find(mixed $value, bool $try): ?EnumCase {
if ($try) {
return null;
} else {
throw new ValueError("value {$value} cannot be represented as a value in enum ".static::class);
throw new \moodle_exception("value {$value} cannot be represented as a value in enum ".static::class);
}
}
/**
Expand Down
6 changes: 3 additions & 3 deletions lbplanner/services/plan/set_deadline.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,10 @@ public static function set_deadline(int $moduleid, int $deadlinestart, int $dead
throw new \moodle_exception('Access denied');
}

// If a deadline already exists.
if (!$DB->record_exists(plan_helper::DEADLINES_TABLE, ['moduleid' => $moduleid, 'planid' => $planid])) {
$deadline = $DB->get_record(plan_helper::DEADLINES_TABLE, ['moduleid' => $moduleid, 'planid' => $planid]);

if ($deadline !== false) {
// Update the existing deadline.
$deadline = $DB->get_record(plan_helper::DEADLINES_TABLE, ['moduleid' => $moduleid, 'planid' => $planid]);

$deadline->deadlinestart = $deadlinestart;
$deadline->deadlineend = $deadlineend;
Expand Down
Loading