lpp-31: impl task type dropdown in activity#42
Merged
Conversation
RiedleroD
changed the title
Contributor
Author
|
changes should now be on the testserver. I don't expect this to work first try though |
mcquenji
requested changes
Dec 19, 2024
Contributor
mcquenji
left a comment
mcquenji
left a comment
There was a problem hiding this comment.
seems to be working, however there is an empty option?
Contributor
Author
|
the empty option is moodle being moodle. Best I can do is select empty as default and hope people interpret it as "this field is empty atm, but you need to set it to a value" edit: good news! I already did that 2 weeks ago and just forgot to push |
Contributor
Author
|
merge blocked by #43 because we modify some imports |
RiedleroD
force-pushed
the
lpp-31-impl-task-type
branch
from
f7e8dd2 to
46717c8
Compare
mcquenji
approved these changes
Jan 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
most of this code was actually @Muhiiii 's, I just recycled it. Let's hope this even works 😓 all of this is poorly documented and confusing to me.