Skip to content

fix: Module endpoints (lpp-48) #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RiedleroD merged 1 commit into from
Jan 18, 2025
Merged

fix: Module endpoints (lpp-48) #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lbplanner/classes/helpers/modules_helper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,15 +147,19 @@ public static function map_status(bool $submitted, bool $done, bool $late): int
*
* @param int $moduleid The ID of the module.
* @return int The enum value for the module type.
* @throws \moodle_exception
*/
public static function determine_type(int $moduleid): int {
$catid = config_helper::get_category_id();
if ($catid === -1) {
throw new \moodle_exception('couldn\'t find custom fields category ID');
}
$categorycontroller = category_controller::create($catid);
$datacontroller = $categorycontroller->get_handler()->get_instance_data($moduleid)[0];
$type = intval($datacontroller->get('value'));
$instancedata = $categorycontroller->get_handler()->get_instance_data($moduleid);
if (count($instancedata) === 0) {
throw new \moodle_exception("couldn't find any instance data for module ID {$moduleid} in category ID {$catid}");
}
$type = intval($instancedata[1]->get('value')); // NOTE: why the hell is this on index one?
MODULE_TYPE::name_from($type); // Basically asserting that this value exists as a module type.
return $type;
}
Expand Down
Loading