Skip to content

fix: Remove $lang from remaining user API #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RiedleroD merged 2 commits into from
Jan 20, 2025
Merged

fix: Remove $lang from remaining user API #55

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0c1e66
fix: remove $lang from remaining user API
RiedleroD Jan 20, 2025
182438d
fix: docstring
RiedleroD Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions lbplanner/services/user/update_user.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ class user_update_user extends external_api {
*/
public static function update_user_parameters(): external_function_parameters {
return new external_function_parameters([
'lang' => new external_value(PARAM_TEXT, 'The language the user has selected', VALUE_DEFAULT, null),
'theme' => new external_value(PARAM_TEXT, 'The theme the user has selected', VALUE_DEFAULT, null),
'colorblindness' => new external_value(
PARAM_TEXT,
Expand All @@ -56,7 +55,6 @@ public static function update_user_parameters(): external_function_parameters {

/**
* Updates the given user in the lbplanner DB
* @param string $lang language the user choose
* @param string $theme The theme the user has selected
* @param string $colorblindness The colorblindness the user has selected
* @param int $displaytaskcount The displaytaskcount the user has selected
Expand All @@ -65,13 +63,12 @@ public static function update_user_parameters(): external_function_parameters {
* @throws dml_exception
* @throws invalid_parameter_exception
*/
public static function update_user($lang, $theme, $colorblindness, $displaytaskcount): array {
public static function update_user($theme, $colorblindness, $displaytaskcount): array {
global $DB, $USER;

self::validate_parameters(
self::update_user_parameters(),
[
'lang' => $lang,
'theme' => $theme,
'colorblindness' => $colorblindness,
'displaytaskcount' => $displaytaskcount,
Expand All @@ -83,9 +80,6 @@ public static function update_user($lang, $theme, $colorblindness, $displaytaskc
throw new moodle_exception('User does not exist');
}
$user = user_helper::get_user($USER->id);
if ($lang !== null) {
$user->set_lang($lang);
}
if ($colorblindness !== null) {
$user->set_colorblindness($colorblindness);
}
Expand Down
Loading