Skip to content

fix: Protect against $maxgrade being equal to $gradepass#67

Merged
RiedleroD merged 2 commits intomainfrom
fix-divnull
Feb 13, 2025
Merged

fix: Protect against $maxgrade being equal to $gradepass#67
RiedleroD merged 2 commits intomainfrom
fix-divnull

Conversation

@RiedleroD
Copy link
Contributor

@RiedleroD RiedleroD commented Feb 13, 2025

fixes lpp-67

@RiedleroD RiedleroD requested a review from mcquenji February 13, 2025 01:10
@RiedleroD RiedleroD self-assigned this Feb 13, 2025
@RiedleroD RiedleroD marked this pull request as draft February 13, 2025 01:11
@RiedleroD RiedleroD changed the title fix: protect against $maxgrade being equal to $gradepass fix: Protect against $maxgrade being equal to $gradepass Feb 13, 2025
@RiedleroD
Copy link
Contributor Author

yep, this fixes it. I was able to reproduce the error in main, and it's fixed in this branch.

@RiedleroD RiedleroD marked this pull request as ready for review February 13, 2025 11:27
Copy link
Contributor

@mcquenji mcquenji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RiedleroD RiedleroD merged commit 7fe4b23 into main Feb 13, 2025
4 checks passed
@RiedleroD RiedleroD deleted the fix-divnull branch February 13, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants