Skip to content

fix: Less flaky kanban_helper::set_entry() #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RiedleroD merged 1 commit into from
Nov 13, 2025
Merged

fix: Less flaky kanban_helper::set_entry() #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 10 additions & 14 deletions lbplanner/classes/helpers/kanban_helper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,22 +69,18 @@ public static function get_entry(int $userid, int $cmid): ?kanbanentry {
* @param kanbanentry $entry the entry to set
*/
public static function set_entry(kanbanentry $entry): void {
global $DB, $CFG;
global $DB;

try {
if ($entry->column === KANBANCOL_TYPE_NUMERIC::BACKLOG) {
$DB->delete_records(self::TABLE, ['userid' => $entry->userid, 'cmid' => $entry->cmid]);
} catch (\dml_exception $e) {
// Needed for low-reporting contexts such as a prod server.
echo 'error while trying to delete preexisting kanban entries: '
. $e->getMessage()
. "\nFurther info:\n"
. $e->debuginfo;
var_dump($entry);
throw $e;
}
if ($entry->column !== KANBANCOL_TYPE_NUMERIC::BACKLOG) {
$newid = $DB->insert_record(self::TABLE, $entry->prepare_for_db(), true);
$entry->set_fresh($newid);
} else {
$id = $DB->get_field(self::TABLE, 'id', ['userid' => $entry->userid, 'cmid' => $entry->cmid], IGNORE_MISSING);
if ($id === false) {
$id = $DB->insert_record(self::TABLE, $entry->prepare_for_db(), true);
} else {
$DB->set_field(self::TABLE, 'selectedcolumn', $entry->column, ['id' => $id]);
}
$entry->set_fresh($id);
}
}
}
Loading