-
Notifications
You must be signed in to change notification settings - Fork 8
Mistral tools #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mistral tools #89
Conversation
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: dtolnay/rust-toolchain@1.87 | ||
| - uses: dtolnay/rust-toolchain@1.89 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to update rust version as some of the AWS crates require 88+
chance-neferdata
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| //Prepare the 'messages' part of the body | ||
| let base_instructions = self.get_base_instructions(Some(function_call)); | ||
| let system_message = json!({ | ||
| "role": "system", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just learned about system messages. Neat. I wonder if there's any noticeable difference if we were to provide output schema here as well. Probably not an issue, just a new idea to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth trying eventually. Not sure how it will behave differently. Some models provide json mode but I have generally found it pretty unreliable.
No description provided.