Skip to content

Conversation

@kamillitman
Copy link
Contributor

No description provided.

steps:
- uses: actions/checkout@v3
- uses: dtolnay/rust-toolchain@1.87
- uses: dtolnay/rust-toolchain@1.89
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to update rust version as some of the AWS crates require 88+

Copy link
Collaborator

@chance-neferdata chance-neferdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

//Prepare the 'messages' part of the body
let base_instructions = self.get_base_instructions(Some(function_call));
let system_message = json!({
"role": "system",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just learned about system messages. Neat. I wonder if there's any noticeable difference if we were to provide output schema here as well. Probably not an issue, just a new idea to me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth trying eventually. Not sure how it will behave differently. Some models provide json mode but I have generally found it pretty unreliable.

@kamillitman kamillitman merged commit 065f883 into main Nov 12, 2025
1 check passed
@kamillitman kamillitman deleted the mistral-tools branch November 12, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants