Generate email forwarding mappings for staff position email aliases #11109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests verify that EmailForwardingRouter.all_staff_position_mappings correctly generates email forwarding mappings for both the primary staff position email and all configured email aliases. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
EmailForwardingRouter.all_staff_position_mappingsto generate email forwarding mappings for staff position email aliases in addition to the primary email addressChanges
Service Fix (
app/services/email_forwarding_router.rb)Changed from using
maptoflat_mapto generate multiple mappings per staff position:staff@example.com)help@example.com,support@example.com)All aliases route to the same destination addresses (staff member emails + CC addresses).
Tests (
test/services/email_forwarding_router_test.rb)Added new test file with comprehensive coverage:
Test Results
All 4 tests passing with 23 assertions.
🤖 Generated with Claude Code