Skip to content

[Snyk] Upgrade @apollo/client from 3.7.7 to 3.13.8 #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nejidevelops wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Snyk] Upgrade @apollo/client from 3.7.7 to 3.13.8 #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
110 changes: 71 additions & 39 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"@angular/platform-browser": "~15.1.0",
"@angular/platform-browser-dynamic": "~15.1.0",
"@angular/router": "~15.1.0",
"@apollo/client": "^3.7.7",
"@apollo/client": "^3.13.8",
Copy link

@gemini-code-assist gemini-code-assist bot May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This PR proposes upgrading @apollo/client from ^3.7.7 to ^3.13.8. The PR description and Snyk metadata list the release date for version 3.13.8 as 2025-04-17. This future release date is a significant concern and needs immediate clarification.

Could you please verify the following:

  1. Is 3.13.8 the correct and stable version intended for this upgrade? Publicly available information (e.g., npmjs.com) as of May 2024 suggests that stable versions are around 3.9.x or 3.10.x release candidates.
  2. What is the actual release date and stability status of version 3.13.8?

Upgrading to a potentially non-existent, misdated, or unstable pre-release version could introduce significant risks to the application's stability and security.

If this version is indeed valid (e.g., from a specific, trusted release channel not yet public on npmjs.com), please ensure it's appropriate for your project's stability requirements. Even if validated, the substantial version jump (125 versions according to the PR description) necessitates thorough testing across all application areas that utilize Apollo Client. This includes, but is not limited to, queries, mutations, caching behavior, and any custom links or configurations.

"@firebase/firestore-types": "^2.5.1",
"@google-cloud/secret-manager": "^4.2.2",
"@google/maps": "^1.1.3",
Expand Down