Add the injection point for testing SMGR v18#902
Draft
a-masterov wants to merge 4 commits intoREL_18_STABLE_neonfrom
Draft
Add the injection point for testing SMGR v18#902a-masterov wants to merge 4 commits intoREL_18_STABLE_neonfrom
a-masterov wants to merge 4 commits intoREL_18_STABLE_neonfrom
Conversation
|
Can’t you install an SMGR that has these changes builtin, instead of modifying PG's code? It seems quite simple to me to have one that has these interrupts and otherwise lets that other SMGR resolve the requests. |
HaoyuHuang
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to test SMGR failures.
This PR adds two features:
SMGR_API injection point in CHECK_FOR_INTERRUPTS – Injection can run even when there are no pending interrupts, and is gated by an
inside_smgr_apicounter for use by Neon’s SMGR layer.Probability-based injection in the injection_points extension – New error-prob- action so injection points can raise an ERROR with a configurable probability (e.g. for fault-injection tests).
Reference: https://databricks.atlassian.net/browse/LKB-6690