Open
Conversation
Contributor
LeonLi000
commented
Sep 26, 2020
LeonLi000
commented
- support cross-chain from Ethereum to ckb. Including spv verification and checking whether the transaction is on the main chain.
- test cases for spv verification and header verification.
Co-authored-by: zhounan <vyclzn@gmail.com>
Co-authored-by: zhounan <vyclzn@gmail.com>
Co-authored-by: zhounan <vyclzn@gmail.com>
…ness.mol Co-authored-by: zhounan <vyclzn@gmail.com>
Co-authored-by: Ethan Hu <ludeweishadiao@163.com>
Co-authored-by: zhounan <vyclzn@gmail.com>
Co-authored-by: zhounan <vyclzn@gmail.com>
2. finish test cases for mint_xt with eth. Merge remote-tracking branch 'upstream/master' into spv
ghost
reviewed
Sep 28, 2020
Comment on lines
+244
to
+248
| pub fn verify_eth_witness( | ||
| data: &ToCKBCellDataView, | ||
| proof: &[u8], | ||
| cell_dep_index_list: &[u8], | ||
| ) -> Result<EthExtraView, Error> { |
There was a problem hiding this comment.
two questions here:
- Miss lock amount verification?
- Dose eth-transfer tx have a receipt?
If dosen't, we should verify the tx-structure rather than receipt
for full support of eth <-> ckb, we still need to add eth-feature to theses transactions:
of course, we will do this in other PRs |
ghost
added
the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.