Rollback change making datafields endpoint not work#488
Merged
thomasegense merged 4 commits intonetarchivesuite:masterfrom Jan 20, 2026
Merged
Rollback change making datafields endpoint not work#488thomasegense merged 4 commits intonetarchivesuite:masterfrom
thomasegense merged 4 commits intonetarchivesuite:masterfrom
Conversation
Contributor
|
Since the release is out, I need to patch fast. I will make a 3.4.1 release. For future PR we probably need to have @jesperlauridsen review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, I wanted to make an endpoint return pretty and valid JSON. This broke the show datafields button in the frontend. This rolls back the change.
You should probably release a patch version of this. Sorry for the inconvinience.