Skip to content

Conversation

@SunDevil311
Copy link
Member

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Added

  • Added revised QR code image assets for Vcard information:
    • src/lib/img/qr/vcard.png
    • src/lib/img/qr/vcard.webp

Changed

  • Modified .node-version and .nvmrc to utilize Node.js 24.11.1 (LTS).
  • Updated .ncurc.cjs to reject updates to markdownlint-cli2, due to discrepancies between in-editor and CLI linting errors.
  • Updated environment template (.env.template) to include PUBLIC_ENV_MODE, which is now required to build the proper environment (e.g., dev, audit, production).
  • Updated generator metadata in src/app.html to reflect SvelteKit 2.48.5.
  • Bumped project version to v1.25.12.
  • Updated dependencies:
    • @sveltejs/kit 2.48.42.48.5
    • eslint-plugin-jsdoc ^61.2.0^61.2.1

Checklist

  • I have read and followed the guidelines in the CONTRIBUTING document.
  • I've checked for existing Pull Requests for the same update/change.
  • My code follows the project’s coding style.
  • My code has been linted locally before submission.
  • All new and existing tests pass.

 

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes, if applicable. (Optional, especially for new contributors)

Pull requests are part of a collaborative process — we welcome contributions and review each one carefully. For all but the smallest changes, you can expect maintainers to request improvements or clarifications.

Please check back after opening your PR and be responsive to feedback so we can get your contribution merged quickly.

Thanks for helping improve Network Pro Strategies!

@vercel
Copy link

vercel bot commented Nov 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
web Ready Ready Preview Nov 14, 2025 11:23am

@github-actions
Copy link

⚠️ Lighthouse Budget Issues Detected

  • First Contentful Paint (score: 0.92)
  • Largest Contentful Paint (score: 0.81)
  • Speed Index (score: 0.92)
  • Total Blocking Time (score: 0.72)
  • Max Potential First Input Delay (score: 0.75)
  • Reduce initial server response time (score: 0)
  • Time to Interactive (score: 0.96)
  • Minimize main-thread work (score: 0)
  • Largest Contentful Paint element (score: 0)
  • Links rely on color to be distinguishable. (score: 0)
  • Reduce unused CSS (score: 0)
  • Document request latency (score: 0)
  • Optimize DOM size (score: 0)
  • Network dependency tree (score: 0)
  • Render blocking requests (score: 0.5)

View the full report in the workflow artifacts or in .lighthouseci/report.html.

Copy link
Member Author

@SunDevil311 SunDevil311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look good. Merging pending successful completion of tests.

@SunDevil311 SunDevil311 merged commit 830fbbb into master Nov 14, 2025
12 of 13 checks passed
@SunDevil311 SunDevil311 deleted the feature/qr-codes branch November 14, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants