Skip to content

Conversation

@SunDevil311
Copy link
Member

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Added

  • Added SSR boundary protection test (tests/unit/server/internal/ssrBoundary.test.js):
    • Detects Node-only imports (jsdom, fs, path, etc.) in client-visible modules.
    • Ensures imports are properly gated behind import.meta.env.SSR.
    • Prevents accidental SSR/client boundary violations in future code changes.
  • Added support for detecting SSR-safe code paths by allowing SSR-gated dynamic imports in shared modules.

Changed

  • Refactored src/service-worker.js for improved consistency, clarity, and lint compatibility:

    • Removed unused function parameters (_err) and adjusted callback signatures to align with ESLint expectations.
    • Replaced anonymous no-op parameters with explicitly ignored placeholders using the _ naming convention.
    • Improved async iteration patterns in asset caching logic for better readability and maintainability.
    • Updated JSDoc annotations for accuracy and improved editor support.
    • Ensured all cache operations conform to structured error-handling patterns consistent with the rest of the codebase.
  • Updated src/lib/utils/purify.js:

    • Replaced typeof window !== 'undefined' guard with compile-time import.meta.env.SSR.
    • Ensures Vite tree-shakes jsdom imports from client bundles.
    • Fixed build failures caused by jsdom/cssstyle when bundled on the client.
    • Preserves existing DOMPurify caching and SSR behavior.
  • Enhanced ESLint no-unused-vars rule in eslint.config.mjs:

    • Added support for ignoring unused catch parameters via caughtErrors and caughtErrorsIgnorePattern.
    • Prevented false positives on intentionally unused error variables (e.g., _err).
    • Expanded ignore patterns to match project coding conventions.
  • Replaced src/lib/img/qr/vcard.png and src/lib/img/qr/vcard.webp with revised versions.

  • Updated GitHub workflows to utilize npm 11.7.0.

  • Updated generator metadata in src/app.html to reflect SvelteKit 2.49.2.

  • Updated src/lib/README.md to reflect the newly updated app constant.

  • Updated contact information in static/bin/contact.vcf.

  • Updated CONTACT.PHONE app constant to reflect our new phone number, (602) 428-5300.

  • Removed jsdom from .ncurc.cjs reject list.

  • Bumped project version to v1.25.17.

  • Updated dependencies:

    • dompurify ^3.3.0^3.3.1
    • posthog-js ^1.295.0^1.305.0
    • svelte 5.43.125.45.9
    • @playwright/test ^1.56.1^1.57.0
    • @sveltejs/adapter-vercel ^6.1.1^6.2.0
    • @sveltejs/kit 2.48.52.49.2
    • browserslist ^4.28.0^4.28.1
    • eslint-plugin-jsdoc ^61.2.1^61.5.0
    • eslint-plugin-svelte ^3.13.0^3.13.1
    • markdownlint ^0.39.0^0.40.0
    • markdownlint-cli2 0.19.00.20.0
    • playwright ^1.56.1^1.57.0
    • stylelint ^16.25.0^16.26.1
    • svelte-eslint-parser ^1.4.0^1.4.1
    • vite ^7.2.2^7.2.7
    • jsdom 26.1.027.3.0

Fixed

  • Resolved client-side build failures caused by dynamic jsdom imports leaking into the Vite dependency graph.
  • Resolved false positive ESLint errors for unused catch bindings in JS modules.

Checklist

  • I have read and followed the guidelines in the CONTRIBUTING document.
  • I've checked for existing Pull Requests for the same update/change.
  • My code follows the project’s coding style.
  • My code has been linted locally before submission.
  • All new and existing tests pass.

 

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes, if applicable. (Optional, especially for new contributors)

Pull requests are part of a collaborative process — we welcome contributions and review each one carefully. For all but the smallest changes, you can expect maintainers to request improvements or clarifications.

Please check back after opening your PR and be responsive to feedback so we can get your contribution merged quickly.

Thanks for helping improve Network Pro Strategies!

@vercel
Copy link

vercel bot commented Dec 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
web Ready Ready Preview Dec 12, 2025 2:18am

@github-actions
Copy link

⚠️ Lighthouse Budget Issues Detected

  • First Contentful Paint (score: 0.93)
  • Largest Contentful Paint (score: 0.76)
  • Speed Index (score: 0.98)
  • Cumulative Layout Shift (score: 0.99)
  • Time to Interactive (score: 0.95)
  • Links rely on color to be distinguishable. (score: 0)
  • Reduce unused CSS (score: 0)
  • Network dependency tree (score: 0)
  • Render blocking requests (score: 0.5)

View the full report in the workflow artifacts or in .lighthouseci/report.html.

Copy link
Member Author

@SunDevil311 SunDevil311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All files look good. Merging.

@SunDevil311 SunDevil311 merged commit 18d5f4d into master Dec 12, 2025
12 checks passed
@SunDevil311 SunDevil311 deleted the feature/update-sw-and-deps branch December 12, 2025 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants