Skip to content

New template Alcatel AOS: show mac-address-table #1902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmcgill298 merged 9 commits into from
Nov 27, 2024
Merged

New template Alcatel AOS: show mac-address-table #1902

jmcgill298 merged 9 commits into from
Nov 27, 2024

Conversation

@evilmonkey19
Copy link
Contributor

@evilmonkey19 evilmonkey19 commented Nov 19, 2024

No description provided.

@evilmonkey19
Copy link
Contributor Author

evilmonkey19 commented Nov 19, 2024

Added support for R8 version where the command is show mac-learning. In the R6 version the command is show mac-address-table. I wanted to combine both commands to simplify everything as Alcatel decided to make it difficult :)

jmcgill298
jmcgill298 requested changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@jmcgill298 jmcgill298 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one adjustment @evilmonkey19

@mjbear
Copy link
Collaborator

mjbear commented Nov 21, 2024

@evilmonkey19
I'd be glad to submit further suggestions if you're willing to accept them via GitHub workflow (Commit Suggestion).
Thank you! 🙂

@mjbear
Copy link
Collaborator

mjbear commented Nov 22, 2024

@evilmonkey19 I'd be glad to submit further suggestions if you're willing to accept them via GitHub workflow (Commit Suggestion). Thank you! 🙂

@evilmonkey19
I'm having issues trying to compare a branch on my fork to a branch on your fork.
Would you please sync your fork's master branch as an attempt to fix this?

@evilmonkey19
Copy link
Contributor Author

evilmonkey19 commented Nov 25, 2024 •
edited
Loading

I synced the fork now :)

@mjbear
Copy link
Collaborator

mjbear commented Nov 25, 2024

I synced the fork now :)

Thank you.
Hmm, GitHub still doesn't want to show me your fork in order for me to submit a PR against your fork.

Oh well, I can work off of the code review page as we've been doing.
Thank you for collaborating with me! 😁

@jmcgill298 jmcgill298 merged commit d23821d into networktocode:master Nov 27, 2024
14 checks passed
@mjbear mjbear mentioned this pull request Nov 28, 2024
Merged
@evilmonkey19 evilmonkey19 deleted the alcatel_aos_show_mac-address-table branch February 24, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmcgill298 jmcgill298 jmcgill298 approved these changes

@itdependsnetworks itdependsnetworks Awaiting requested review from itdependsnetworks itdependsnetworks is a code owner

@jvanderaa jvanderaa Awaiting requested review from jvanderaa jvanderaa is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@evilmonkey19 @mjbear @jmcgill298