Skip to content

Conversation

@disooqi
Copy link

@disooqi disooqi commented Sep 11, 2018

I just created a map for the Arab world within it context in the middle east. I added three files: 1) "arabworld2.js" which contains the actual map data 2) "index.js" which contain js code to highlight the Arabic countries, and finally 3) "index.html" that only shows the map in a webpage

@neveldo
Copy link
Owner

neveldo commented Oct 23, 2018

Hello @disooqi ,

Sorry for my late answer, and thanks a lot for your contribution to the repository ! Some things should be fixed before your PR being able to be merged into the master branch :

  • The directory that contain your map should be in written in snake case : "arab_world" instead of "Arab world".
  • This repository only contains raw maps for jQuery Mapael, there is no demo files. So the arab_world should contain only the JS of your map.
  • In arabworld2.js, the IDs of the areas seem to be inconsistent "sd-", "ly", "path2190". The paths should be identified properly (for instance with ISO contry or area IDs) in order to ease the use of your map.

Feel free to take a look at the other map added in this repository, for instance : https://github.com/neveldo/mapael-maps/tree/7ef1b5c7cc0f820e63dac0cbfeef47392b74988c/croatia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants