Extract security score logic, wire UI score tab, and add unit tests#8
Open
peopleinfo wants to merge 11 commits intomainfrom
Open
Extract security score logic, wire UI score tab, and add unit tests#8peopleinfo wants to merge 11 commits intomainfrom
peopleinfo wants to merge 11 commits intomainfrom
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| app.on("gpu-process-crashed", (event, killed) => { | ||
| console.error("[GPU] GPU process crashed, killed:", killed); | ||
| if (typeof scheduleActiveBrowserViewRecovery === "function") { | ||
| scheduleActiveBrowserViewRecovery({ type: "gpu", killed }); |
Comment on lines
+92
to
+95
| scheduleActiveBrowserViewRecovery({ | ||
| type: details.type, | ||
| reason: details.reason, | ||
| }); |
|
|
||
| function createWindow({ show = true } = {}) { | ||
| const shouldShow = Boolean(show); | ||
| const trayIcon = resolveAppIcon({ |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
getSecurityScorehelper inapps/ui/src/renderer/src/lib/securityScore.jsthat computesstats,activeProxy,protectionChecks,protectionScore,normalizedScore,scoreLabel, andscoreTonefromprofiles,proxies, andactiveProfileId.AntiBrowserViewto usegetSecurityScoreand render the newSecurity Scoretab with score meter, network identity, protection coverage, checklist, and guidance (UI changes inapps/ui/src/renderer/src/views/AntiBrowserView.jsx).apps/ui/tests/unit/security-score.test.jsthat validate the baseline score and a fully-protected scenario where all protections and an active proxy produce a high score.Testing
apps/ui/tests/unit/security-score.test.js) covering the baseline case (no data ->normalizedScore === 30,scoreLabel === "Low") and the full-protection case (all protections + active proxy ->protectionScore === 6,normalizedScore === 100,scoreLabel === "High").Codex Task