Declarative UI #1836

tobiasKaminsky · 2025-09-22T12:02:56Z

No description provided.

github-actions · 2025-09-22T12:05:29Z

SpotBugs

Category	Base	New
Bad practice	34	34
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	11	11
Performance	8	8
Total	168	168

github-actions · 2025-09-25T11:14:45Z

SpotBugs

Category	Base	New
Bad practice	34	34
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	11	11
Performance	8	8
Total	168	168

github-actions · 2025-10-07T07:32:11Z

SpotBugs

Category	Base	New
Bad practice	34	34
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	11	11
Performance	8	8
Total	168	168

github-actions · 2025-10-07T07:39:29Z

SpotBugs

Category	Base	New
Bad practice	34	34
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	11	11
Performance	8	8
Total	168	168

github-actions · 2025-12-10T07:46:29Z

SpotBugs

Category	Base	New
Bad practice	34	34
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	11	11
Performance	8	8
Total	168	168

github-actions · 2025-12-10T12:21:14Z

SpotBugs

Category	Base	New
Bad practice	34	34
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	11	11
Performance	8	8
Total	168	168

github-actions · 2025-12-17T06:38:38Z

SpotBugs

Category	Base	New
Bad practice	34	34
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	11	11
Performance	8	8
Total	168	168

library/src/androidTest/java/com/owncloud/android/AbstractIT.java

library/src/main/java/com/nextcloud/android/lib/resources/clientintegration/App.kt

...ry/src/main/java/com/nextcloud/android/lib/resources/clientintegration/ElementTypeAdapter.kt

...a/com/nextcloud/android/lib/resources/clientintegration/GetClientIntegrationJsonOperation.kt

library/src/main/java/com/nextcloud/android/lib/resources/clientintegration/Row.kt

library/src/main/java/com/nextcloud/android/lib/resources/clientintegration/TooltipResponse.kt

...a/com/nextcloud/android/lib/resources/clientintegration/GetClientIntegrationJsonOperation.kt

library/src/main/java/com/owncloud/android/lib/resources/status/Method.kt

github-actions · 2025-12-17T12:06:50Z

SpotBugs

Category	Base	New
Bad practice	34	34
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	11	11
Performance	8	8
Total	168	168

github-actions · 2025-12-17T13:57:40Z

SpotBugs

Category	Base	New
Bad practice	34	34
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	11	11
Performance	8	8
Total	168	168

...y/src/main/java/com/nextcloud/android/lib/resources/clientintegration/ClientIntegrationUI.kt

github-actions · 2025-12-17T15:25:03Z

SpotBugs

Category	Base	New
Bad practice	34	34
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	11	11
Performance	8	8
Total	168	168

github-actions · 2025-12-19T12:31:06Z

SpotBugs

Category	Base	New
Bad practice	34	34
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	11	11
Performance	8	8
Total	168	168

github-actions · 2025-12-19T13:28:57Z

SpotBugs

Category	Base	New
Bad practice	34	34
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	11	11
Performance	8	8
Total	168	168

github-actions · 2025-12-19T13:39:16Z

SpotBugs

Category	Base	New
Bad practice	34	34
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	11	11
Performance	8	8
Total	168	168

github-actions · 2025-12-19T13:59:27Z

SpotBugs

Category	Base	New
Bad practice	34	34
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	11	11
Performance	8	8
Total	168	168

github-actions · 2025-12-19T14:10:41Z

SpotBugs

Category	Base	New
Bad practice	34	34
Correctness	34	34
Dodgy code	26	26
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	11	11
Performance	8	8
Total	168	168

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Signed-off-by: alperozturk <alper_ozturk@proton.me>

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

Signed-off-by: alperozturk <alper_ozturk@proton.me>

github-actions · 2026-01-12T08:36:55Z

SpotBugs

Category	Base	New
Bad practice	34	34
Correctness	34	34
Dodgy code	25	25
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	11	11
Performance	8	8
Total	167	167

nextcloud-android-bot · 2026-01-12T08:54:10Z

stable-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/4838-IT-stable-08-53/debug/

nextcloud-android-bot · 2026-01-12T08:57:44Z

master-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/4838-IT-master-08-56/debug/

alperozturk96 · 2026-01-12T10:03:23Z

@tobiasKaminsky Some tests are failing ??

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

codecov · 2026-01-12T13:38:55Z

Codecov Report

❌ Patch coverage is 28.70370% with 77 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
.../resources/clientintegration/ElementTypeAdapter.kt	0.00%	18 Missing ⚠️
...ndroid/lib/resources/clientintegration/Endpoint.kt	20.00%	8 Missing ⚠️
.../android/lib/resources/clientintegration/Layout.kt	0.00%	6 Missing ⚠️
...cloud/android/lib/resources/status/OCCapability.kt	73.91%	2 Missing and 4 partials ⚠️
...resources/clientintegration/ClientIntegrationUI.kt	0.00%	5 Missing ⚠️
...id/lib/resources/clientintegration/LayoutButton.kt	0.00%	5 Missing ⚠️
...droid/lib/resources/clientintegration/LayoutURL.kt	0.00%	5 Missing ⚠️
...oid/lib/resources/clientintegration/LayoutImage.kt	0.00%	4 Missing ⚠️
...b/resources/clientintegration/LayoutOrientation.kt	0.00%	4 Missing ⚠️
...droid/lib/resources/clientintegration/LayoutRow.kt	0.00%	4 Missing ⚠️
... and 5 more

📢 Thoughts on this report? Let us know!

github-actions · 2026-01-12T13:49:47Z

SpotBugs

Category	Base	New
Bad practice	34	34
Correctness	34	34
Dodgy code	25	25
Internationalization	6	6
Malicious code vulnerability	49	49
Multithreaded correctness	11	11
Performance	8	8
Total	167	167

tobiasKaminsky force-pushed the declarative-ui branch from 46595dc to 09cf421 Compare October 7, 2025 07:28

tobiasKaminsky force-pushed the declarative-ui branch from e424b9f to be1621e Compare December 10, 2025 07:42

tobiasKaminsky mentioned this pull request Dec 10, 2025

Declarative protocol: dynamic menu entries in clients nextcloud/files-clients#86

Open

2 tasks

tobiasKaminsky force-pushed the declarative-ui branch 2 times, most recently from 12510b0 to 373cb73 Compare December 10, 2025 11:50

tobiasKaminsky marked this pull request as ready for review December 10, 2025 11:50

tobiasKaminsky requested a review from alperozturk96 December 17, 2025 06:34

tobiasKaminsky added the approved label Dec 17, 2025

tobiasKaminsky force-pushed the declarative-ui branch from 373cb73 to c8eff09 Compare December 17, 2025 06:34

alperozturk96 requested changes Dec 17, 2025

View reviewed changes

...a/com/nextcloud/android/lib/resources/clientintegration/GetClientIntegrationJsonOperation.kt Outdated Show resolved Hide resolved

library/src/main/java/com/owncloud/android/lib/resources/status/Method.kt Show resolved Hide resolved

alperozturk96 requested changes Dec 17, 2025

View reviewed changes

...y/src/main/java/com/nextcloud/android/lib/resources/clientintegration/ClientIntegrationUI.kt Outdated Show resolved Hide resolved

alperozturk96 force-pushed the declarative-ui branch from f51ba3b to 1639bf8 Compare December 19, 2025 13:36

alperozturk96 previously approved these changes Dec 19, 2025

View reviewed changes

Client integration

a440aaf

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

alperozturk96 and others added 7 commits January 12, 2026 09:34

make orientation parcable and add tests

06fce6d

Signed-off-by: alperozturk <alper_ozturk@proton.me>

update

fe22bd4

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

ClientIntegrationUI root might be null

b67565e

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

change layout item names

d42f42e

Signed-off-by: alperozturk <alper_ozturk@proton.me>

remove unused element

23b1f77

Signed-off-by: alperozturk <alper_ozturk@proton.me>

fix adapter

c0fbc30

Signed-off-by: alperozturk <alper_ozturk@proton.me>

fix adapter

7f61654

Signed-off-by: alperozturk <alper_ozturk@proton.me>

tobiasKaminsky force-pushed the declarative-ui branch from 16fc939 to 7f61654 Compare January 12, 2026 08:34

fix tests

8a9afa1

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

tobiasKaminsky dismissed alperozturk96’s stale review via 8a9afa1 January 12, 2026 13:15

tobiasKaminsky merged commit f4feed3 into master Jan 12, 2026
16 of 18 checks passed

tobiasKaminsky deleted the declarative-ui branch January 12, 2026 14:29

Declarative UI #1836

Declarative UI #1836

Uh oh!

Conversation

tobiasKaminsky commented Sep 22, 2025

Uh oh!

github-actions bot commented Sep 22, 2025

SpotBugs

Uh oh!

github-actions bot commented Sep 25, 2025

SpotBugs

Uh oh!

github-actions bot commented Oct 7, 2025

SpotBugs

Uh oh!

github-actions bot commented Oct 7, 2025

SpotBugs

Uh oh!

github-actions bot commented Dec 10, 2025

SpotBugs

Uh oh!

github-actions bot commented Dec 10, 2025

SpotBugs

Uh oh!

github-actions bot commented Dec 17, 2025

SpotBugs

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 17, 2025

SpotBugs

Uh oh!

github-actions bot commented Dec 17, 2025

SpotBugs

Uh oh!

Uh oh!

github-actions bot commented Dec 17, 2025

SpotBugs

Uh oh!

github-actions bot commented Dec 19, 2025

SpotBugs

Uh oh!

github-actions bot commented Dec 19, 2025

SpotBugs

Uh oh!

github-actions bot commented Dec 19, 2025

SpotBugs

Uh oh!

github-actions bot commented Dec 19, 2025

SpotBugs

Uh oh!

github-actions bot commented Dec 19, 2025

SpotBugs

Uh oh!

github-actions bot commented Jan 12, 2026

SpotBugs

Uh oh!

nextcloud-android-bot commented Jan 12, 2026

Uh oh!

nextcloud-android-bot commented Jan 12, 2026

Uh oh!

alperozturk96 commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jan 12, 2026

Codecov Report

Uh oh!

github-actions bot commented Jan 12, 2026

SpotBugs

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

alperozturk96 commented Jan 12, 2026 •

edited

Loading