-
Notifications
You must be signed in to change notification settings - Fork 281
feat(appointments): add duplicate button to clone appointment #7820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Tested works good. |
|
Hi @abhinavohri Code looks good and I have no issue accepting it. Only one change/addition, can we add a "(duplicate)" or "(copy)" to the title once the editor opens. |
|
Hi @SebastianKrupinski , sure I can add that. |
|
Hi @abhinavohri Thank you for the updated PR, but this is not exactly what I had in mind, by title, I meant the "Appointment Name", most users will not look at the modal title.
|
|
@SebastianKrupinski My apologies, I would fix it. Just to be sure the name should be 30 min meeting(duplicate). |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
For translation is there a issue with having "(duplicate)" or should the brackets be separated? |
I would prefer "30 min meeting (copy)."
No, not at all. |
|
@rakekniven I have changed it to "(copy)" |
| if (this.isDuplicate) { | ||
| this.editing.name = `${this.editing.name} (copy)` | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "(copy)" needs to be wrapped in the $t() so that it can be translated... t('calendar', '(copy)')
|
@rakekniven thank you |
|
I am ready to merge these changes, can you squash the commits in to a single commit and rebase to the latest master. Thank you |
Signed-off-by: Abhinav Ohri <abhinavohri13@gmail.com>


Resolves: #7712
Summary:
Added "Duplicate" action button in the three-dot menu for each appointment schedule.
Added a new
isCreatingNewflag inAppointmentConfigListItemto control whether to edit or duplicate the existing config.Before:

After:
