feat: implement AppImage auto-updater for Linux#9269
feat: implement AppImage auto-updater for Linux#9269derspotter wants to merge 2 commits intonextcloud:masterfrom
Conversation
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
nilsding
left a comment
There was a problem hiding this comment.
Thanks for your contribution! Some points:
- Try to make it work without relying on an external shell invocation:
/bin/bashmay not be available on all systems, and the current implementation would break if the AppImage was started from a path such as/home/testing/"; kcalc& "/nextcloud.AppImage - Instead of using merge commits to update your branch, rebase your work on top of the target branch.
- The DCO trailer is missing from your commit message, please read through contribute/developer-certificate-of-origin and if you can certify it add it as per https://github.com/nextcloud/desktop/blob/master/CONTRIBUTING.md#sign-your-work.
I am also curious about the "Fixes" mentioned in the PR description, did you run into those while implementing the AppImageUpdater class?
f9afa45 to
816ee52
Compare
816ee52 to
a3ad495
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-9269.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
mgallien
left a comment
There was a problem hiding this comment.
see my inline comments
please use auto as much as possible
I will try to test it locally
7e77f22 to
02a29e7
Compare
|
I tried to resolve everything in 02a29e7 and kindly ask for a new review. |
|
Update: pushed a fix to keep updater dialogs in the foreground.
|
317fd61 to
b7fc310
Compare
Signed-off-by: der_spotter <jayjag@posteo.de>
Signed-off-by: der_spotter <jayjag@posteo.de>
b7fc310 to
fce3b27
Compare
This PR implements a self-update mechanism for the Linux AppImage.
Changes:
AppImageUpdaterclass (inheritsOCUpdater) to handle AppImage-specific update logic.APPIMAGEenv var).302 Foundredirects to support GitHub Releases downloads.Updater::createfactory to instantiateAppImageUpdateron Linux when applicable.CMakeLists.txtandbuild-appimage.shto include the new files and ensure clean builds.Fixes: