fix(cmd): don't open the database twice with --unsyncedfolders #9410
+0
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoffreyFrogeye
requested review from
Aiiaiiio,
camilasan,
i2h3,
mgallien and
nilsding
as code owners
nilsding
approved these changes
Feb 2, 2026
Member
nilsding
left a comment
nilsding
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contribution!
The openOrCreateReadWrite function is called in checkConnect already, resulting in the database being opened twice in exclusive mode, causing SQLite to complain the database is locked. Closes nextcloud#3422 Signed-off-by: Geoffrey “Frogeye” Preud'homme <geoffrey@frogeye.fr>
nilsding
force-pushed
the
unsyncedfolders-lock
branch
from
c1234d1 to
7e46cc0
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-9410.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The openOrCreateReadWrite function is called in checkConnect already, resulting in the database being opened twice in exclusive mode, causing SQLite to complain the database is locked.
Closes #3422
This bit of code was added in 2015, which was probably working fine before the DB was moved to exclusive mode in 2019. The above issue was created 2 years later. That being said, not being familiar with the code, I am not certain that what I removed is not used for other purposes. So I invite you to take this into consideration while reviewing.