Setting ZipStreaner zip64 = true

[alogoc]

Downloaded zip files larger than 4GB are corrupted. In my case setting "new ZipStreamer(['zip64' => true])" fixed the issue and I believe that this should be the default now since the zip64 issues on older nextcloud versions have been fixed.

[ChristophWurst]

Ref #7972 @rullzer

[Acreen]

I'm really wondering how that fix could help with the problem.

if ($size < 4 * 1000 * 1000 * 1000 && $numberOfFiles < 65536) {
$this->streamerInstance = new ZipStreamer(['zip64' => true]);
} else if ($request->isUserAgent($this->preferTarFor)) {
$this->streamerInstance = new TarStreamer();
} else {
$this->streamerInstance = new ZipStreamer(['zip64' => PHP_INT_SIZE !== 4]);
}

If the file which is causing problems is larger than 4 GB it does not even enter the first if. Shoudln't the fix be in the last else statement? I tried it for me. The difference in behavior was, that it did not cancel the transfer but the zip I downloaded was corrupt. It had the correct size but it was unusable.

Just wondering as I read in older threads that larger files shouldn't be a problem for 32 bit os anymore. I'm using nextcloudpi.

[kesselb]

If the file which is causing problems is larger than 4 GB it does not even enter the first if.

I agree with you. This pr would enable zip64 if the file is smaller than 4gb and has less than 65k files.