fix: don't trigger moveShareInOrOutOfShare for reshares#58121
Open
icewind1991 wants to merge 1 commit intomasterfrom
Open
fix: don't trigger moveShareInOrOutOfShare for reshares#58121icewind1991 wants to merge 1 commit intomasterfrom
icewind1991 wants to merge 1 commit intomasterfrom
Conversation
icewind1991
requested review from
Altahrim,
ArtificialOwl,
leftybournes and
salmart-dev
and removed request for
a team
provokateurin
approved these changes
Feb 5, 2026
artonge
reviewed
Feb 5, 2026
apps/files_sharing/lib/Updater.php
Outdated
Comment on lines
58
to
60
| if ($src->getMountPoint() instanceof SharedMount) { | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
This will always be true, no?
Member
Author
There was a problem hiding this comment.
Narrow it down to only bail out for the root of the share (so the share itself is being moved, not something being moved into a share)
Contributor
There was a problem hiding this comment.
I am really not sure about the new code either. I was not even able to reproduce the scenario of moveShareInOrOutOfShare 🙈.
Can you maybe add a comment at least?
icewind1991
force-pushed
the
move-share-out-share-reshare
branch
from
cfd8f89 to
6127c31
Compare
Member
Author
|
/backport to stable33 |
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
move-share-out-share-reshare
branch
from
6127c31 to
3c7124d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57919 (comment)