-
Notifications
You must be signed in to change notification settings - Fork 509
feat(message-expiry): Add message expiry msg on the right side bar #16690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
5e93b1c to
074b3f4
Compare
|
@Antreesy Apologies for the delay. Addressed review comments on the latest commit and updated the screenshots in the description. Request to re-review |
34ec425 to
3f1fdd0
Compare
| import { showMessage } from '@nextcloud/dialogs' | ||
| import { emit, subscribe, unsubscribe } from '@nextcloud/event-bus' | ||
| import { t } from '@nextcloud/l10n' | ||
| import { getCanonicalLocale, t } from '@nextcloud/l10n' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove all remaining changes from previous commits
| background-color: var(--color-primary-element); | ||
| pointer-events: none; | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And all changes that are not related to the feature
| :color="event.color" /> | ||
| </ul> | ||
| </div> | ||
| <div v-if="isMessageExpirationSet" class="message-expiration"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expected it to be a part of profileInformation, so the line has consistent styles with other information:
| Current | Expected |
|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
This should be enough:
if (conversation.value.messageExpiration > 0) {
const duration = defaultExpirationOptions.find(({ id }) => conversation.value.messageExpiration === id)?.label
?? t('spreed', 'Custom expiration time')
fields.push({
key: 'expiration',
icon: IconDeleteClockOutline,
label: t('spreed', 'Message expiration set: {duration}', { duration }),
})
}There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya But this doesnt show up in group conversation sidebar cause the profileInformation is null. Do you want separate blocks to handle group and 1-1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's happening because of early return in this function and template (checking profileInfo.value === null, these could be removed or adjusted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes right!
6cd62c8 to
1f7c2a2
Compare
|
Almost good to go! Please squash your commit into one, and sign it off (see red CI check for DCO for more information) |
45c7dc0 to
152d956
Compare
Signed-off-by: existentialcoder <shravanayyappa@gmail.com>
152d956 to
915e569
Compare
Hope its good to go. Let me know |






☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist