Skip to content

share label input added #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
memurats merged 2 commits into from
Oct 15, 2025
Merged

share label input added #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb2d152
share label input added
psawalka Oct 14, 2025
6938244
fixed lint issues
psawalka Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion l10n/de.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@
"This share was limited to {limit} downloads. There is still {downloadsLeft} left allowed.": "Diese Freigabe ist auf {limit} Downloads beschränkt. Es sind noch {downloadsLeft} Downloads zugelassen.",
"Deny download": "Download verhindern",
"Name, email": "Name, E-Mail-Adresse",
"Password must be at least 6 characters long": "Passwort muss mindestens 6 Zeichen lang sein"
"Password must be at least 6 characters long": "Passwort muss mindestens 6 Zeichen lang sein",
"Share label": "Ihre Linkbezeichnung"
},
"pluralForm": "nplurals=2; plural=(n != 1);"
}
3 changes: 2 additions & 1 deletion l10n/de_DE.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@
"Deny download": "Download verhindern",
"Name, email": "Name, E-Mail-Adresse",
"Password must be at least 6 characters long": "Passwort muss mindestens 6 Zeichen lang sein",
"Limit needs to be positive number": "Das Limit muss eine positive Zahl sein"
"Limit needs to be positive number": "Das Limit muss eine positive Zahl sein",
"Share label": "Ihre Linkbezeichnung"
},
"pluralForm": "nplurals=2; plural=(n != 1);"
}
3 changes: 2 additions & 1 deletion l10n/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@
"This share was limited to {limit} downloads. There is still {downloadsLeft} left allowed.": "This share was limited to {limit} downloads. There is still {downloadsLeft} left allowed.",
"Deny download": "Deny download",
"Name, email": "Name, email",
"Password must be at least 6 characters long": "Password must be at least 6 characters long"
"Password must be at least 6 characters long": "Password must be at least 6 characters long",
"Share label": "Your custom link label"
},
"pluralForm": "nplurals=2; plural=(n != 1);"
}
3 changes: 2 additions & 1 deletion l10n/en_GB.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@
"Deny download": "Deny download",
"Name, email": "Name, email",
"Password must be at least 6 characters long": "Password must be at least 6 characters long",
"Limit needs to be positive number": "Limit needs to be positive number"
"Limit needs to be positive number": "Limit needs to be positive number",
"Share label": "Your custom link label"
},
"pluralForm": "nplurals=2; plural=(n != 1);"
}
12 changes: 12 additions & 0 deletions src/views/SharingDetailsTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,19 @@
</div>
<div class="sharingTabDetailsView__advanced">
<section>
<NcInputField v-if="isPublicShare"
id="share-label-input"
autocomplete="off"
showTrailingButton

Check warning on line 64 in src/views/SharingDetailsTab.vue

View workflow job for this annotation

GitHub Actions / eslint 

Attribute 'showTrailingButton' must be hyphenated
:label="t('nmcsharing', 'Share label')"
:value.sync="mutableShare.label">
<template #trailing-button-icon>
<PencilIcon :size="16" />
</template>
</NcInputField>
<NcCheckboxRadioSwitch v-if="isPublicShare"
:disabled="canChangeHideDownload"
:checked.sync="share.hideDownload"

Check warning on line 73 in src/views/SharingDetailsTab.vue

View workflow job for this annotation

GitHub Actions / eslint 

Unexpected mutation of "share" prop
@update:checked="queueUpdate('hideDownload')">
{{ t('files_sharing', 'Hide download') }}
</NcCheckboxRadioSwitch>
Expand Down Expand Up @@ -140,6 +150,7 @@
import NcDateTimePickerNative from '@nextcloud/vue/dist/Components/NcDateTimePickerNative.js'
import NcCheckboxRadioSwitch from '@nextcloud/vue/dist/Components/NcCheckboxRadioSwitch.js'
import NcPasswordField from '@nextcloud/vue/dist/Components/NcPasswordField.js'
import NcInputField from '@nextcloud/vue/dist/Components/NcInputField.js'
import EmailIcon from 'vue-material-design-icons/Email.vue'
import LinkIcon from 'vue-material-design-icons/Link.vue'

Expand Down Expand Up @@ -169,6 +180,7 @@
NcDateTimePickerNative,
NcCheckboxRadioSwitch,
NcPasswordField,
NcInputField,
DownloadLimit,
},
mixins: [ShareTypes, ShareRequests, SharesMixin],
Expand Down
Loading