Merged
Conversation
17 tasks
nvnieuwk
reviewed
Feb 12, 2026
Comment on lines
+916
to
+918
| if (obj instanceof Map) { | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
Maps could also contain files?
Member
Author
There was a problem hiding this comment.
Good point, thanks, let me check
Member
Author
There was a problem hiding this comment.
Wait, by map, do you mean a list by any chance?
Member
Author
There was a problem hiding this comment.
I couldn't manage to write a test for that as I don't have an example.
Let's keep this in mind, and fix this when the need arise.
Contributor
There was a problem hiding this comment.
My bad I missunderstood the use case, this is only used in process and workflow outputs, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.