Skip to content

Conversation

@leandrotiburske
Copy link
Collaborator

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 7eb395a

+| ✅ 162 tests passed       |+
#| ❔  25 tests were ignored |#
!| ❗   8 tests had warnings |!
Details

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 3.4.1
  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • schema_lint - Input mimetype is missing or empty
  • schema_description - No description provided in schema for parameter: genome_version_name
  • schema_description - No description provided in schema for parameter: base_dir
  • schema_description - No description provided in schema for parameter: current_config_file
  • schema_description - No description provided in schema for parameter: gtf
  • schema_description - No description provided in schema for parameter: input

❔ Tests ignored:

  • files_exist - File is ignored: conf/igenomes.config
  • files_exist - File is ignored: conf/igenomes_ignored.config
  • files_exist - File is ignored: CODE_OF_CONDUCT.md
  • files_exist - File is ignored: assets/nf-core-genomeprep_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-genomeprep_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-genomeprep_logo_dark.png
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/config.yml
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: assets/multiqc_config.yml
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • files_unchanged - File ignored due to lint config: CODE_OF_CONDUCT.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File does not exist: .github/ISSUE_TEMPLATE/config.yml
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File ignored due to lint config: assets/nf-core-genomeprep_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-genomeprep_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-genomeprep_logo_dark.png
  • files_unchanged - File ignored due to lint config: docs/README.md
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/genomeprep/genomeprep/.github/workflows/awstest.yml
  • multiqc_config - multiqc_config

✅ Tests passed:

Run details

  • nf-core/tools version 3.5.1
  • Run at 2026-01-12 09:22:46

@leandrotiburske
Copy link
Collaborator Author

Hi @matbonfanti !

I hadn't opened PR for these changes Alberto asked for yet, but they are pretty straightforward. I only upgraded the Python app being used to rename some params (e.g., from gene_db to genes_db) and fixed an issue with taxid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant