Added SQL cloud proxy support guide for postgres dependent services#235
Added SQL cloud proxy support guide for postgres dependent services#235priyadarshini-ni wants to merge 12 commits intoni:mainfrom
Conversation
SSSantosh18
left a comment
There was a problem hiding this comment.
Update the similar changes for other services too
SSSantosh18
left a comment
There was a problem hiding this comment.
same comments will apply for other services too
SSSantosh18
left a comment
There was a problem hiding this comment.
remove the unnecessary white space changes if possible
prestwick
left a comment
There was a problem hiding this comment.
I need some clarifications of the parameters that need to be supplied (or not) to enable the auth proxy. Essentially I'm looking for understanding to ensure our inline documentation is complete.
| ## @param sidecars Additional containers to run in the same pod as the Test Monitor Service. | ||
| ## These should be used for authentication proxy containers, such as the Cloud SQL Auth Proxy. | ||
| ## ref: https://cloud.google.com/sql/docs/postgres/connect-kubernetes-engine#run_the_in_a_sidecar_pattern | ||
| sidecars: [] |
There was a problem hiding this comment.
Are uses required to provide a value here? I cannot tell from the reference GCP docs what value to enter here?
There was a problem hiding this comment.
The intention of exposing the parameters sidecars and extraVolumes is to enable the users to configure an extra container which runs along with the service pod. This could also be a Cloud SQL auth proxy container.
The reference documentation has been updated to point to the GCP supplemental values file as this has more information on how the required Cloud SQL authentication proxy container can be configured.
The PR for GCP supplemental values contains more details on the Cloud SQL auth proxy can be configured. The same file can be referenced in the |
This PR is meant to expose the parameters(sidecards, extraVolumes, extraVolumeMounts and serviceAccount) required to configure sidecar containers for the postgres dependent services. |
What does this Pull Request accomplish?
The support guide for adding cloud SQL auth proxy container as sidecar has been added to the services which uses postgres namely testmonitor service, dashboardhosts service and dynamic form fields.
Why should this Pull Request be merged?
What testing has been done?
NA