-
Notifications
You must be signed in to change notification settings - Fork 11
HLD updates for new Spright chat capabilities: welcome and disclaimer #2799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jattasNI
wants to merge
16
commits into
main
Choose a base branch
from
nigel-component-hld
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
a4f9f65
Disclaimer component
jattasNI 99508a2
Welcome component
jattasNI d9d771a
Change files
jattasNI 2deb484
Merge branch 'main' into nigel-component-hld
jattasNI 4104630
welcome message screenshot
jattasNI 509df0c
Update login example
jattasNI 2ca6c8a
Rename welcome component
jattasNI 29a9694
minor tweaks
jattasNI fcb5d67
Merge branch 'main' into nigel-component-hld
jattasNI 47faf24
Merge branch 'main' into nigel-component-hld
jattasNI 7c7967e
Remove disclaimer component, apply style to slot instead
jattasNI 06aeeaa
welcome message updates
jattasNI 6cc1b2b
welcome message structure
jattasNI f6264c7
Merge branch 'main' into nigel-component-hld
jattasNI 20eb5b6
consistent .
jattasNI 71214b9
subtitle
jattasNI File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
change/@ni-spright-components-7e39001e-264a-45c9-9b94-6c5510aab6b0.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "none", | ||
| "comment": "Spec updates for new chat components", | ||
| "packageName": "@ni/spright-components", | ||
| "email": "jattasNI@users.noreply.github.com", | ||
| "dependentChangeType": "none" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+12.8 KB
packages/spright-components/src/chat/specs/spec-images/chat-disclaimer.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+64.4 KB
packages/spright-components/src/chat/specs/spec-images/chat-welcome-login.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.