Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Fix import syntax to obey new lint rule",
"packageName": "@ni/nimble-components",
"email": "jattasNI@users.noreply.github.com",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Fix import syntax to obey new lint rule",
"packageName": "@ni/nimble-react",
"email": "jattasNI@users.noreply.github.com",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Fix import syntax to obey new lint rule",
"packageName": "@ni/spright-angular",
"email": "jattasNI@users.noreply.github.com",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Fix import syntax to obey new lint rule",
"packageName": "@ni/spright-components",
"email": "jattasNI@users.noreply.github.com",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Directive, ElementRef, Input, Renderer2 } from '@angular/core';
import { type ChatInput, chatInputTag } from '@ni/spright-components/dist/esm/chat/input';
import { type ChatInputSendEventDetail } from '@ni/spright-components/dist/esm/chat/input/types';
import type { ChatInputSendEventDetail } from '@ni/spright-components/dist/esm/chat/input/types';

export type { ChatInput };
export type { ChatInputSendEventDetail };
Expand Down
1 change: 1 addition & 0 deletions packages/eslint-config-nimble/typescript.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ export const typescriptNimbleConfigOverrides = defineConfig([
jsdoc,
},
rules: {
'@typescript-eslint/no-import-type-side-effects': 'error',
// Require non-empty JSDoc comment on class declarations
'jsdoc/require-jsdoc': [
'error',
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { Button } from '../../button';
import { waitForUpdatesAsync } from '../../testing/async-helpers';
import { waitTimeout } from '../../utilities/testing/component';
import { type Breadcrumb } from '..';
import type { Breadcrumb } from '..';
import { breadcrumbItemTag } from '../../breadcrumb-item';

/**
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { MenuButton, menuButtonTag } from '@ni/nimble-components/dist/esm/menu-button';
import { type MenuButtonToggleEventDetail } from '@ni/nimble-components/dist/esm/menu-button/types';
import type { MenuButtonToggleEventDetail } from '@ni/nimble-components/dist/esm/menu-button/types';
import { wrap, type EventName } from '../utilities/react-wrapper';
import type { MenuItemChangeEvent } from '../menu-item';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Select, selectTag } from '@ni/nimble-components/dist/esm/select';
import { type SelectFilterInputEventDetail } from '@ni/nimble-components/dist/esm/select/types';
import type { SelectFilterInputEventDetail } from '@ni/nimble-components/dist/esm/select/types';
import { wrap, type EventName } from '../utilities/react-wrapper';

export { selectTag };
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { TableColumnMenuButton, tableColumnMenuButtonTag } from '@ni/nimble-components/dist/esm/table-column/menu-button';
import { type MenuButtonColumnToggleEventDetail } from '@ni/nimble-components/dist/esm/table-column/menu-button/types';
import type { MenuButtonColumnToggleEventDetail } from '@ni/nimble-components/dist/esm/table-column/menu-button/types';
import { wrap, type EventName } from '../../utilities/react-wrapper';

export { tableColumnMenuButtonTag };
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import { html, ViewTemplate } from '@ni/fast-element';
import {
type FoundationElementTemplate
} from '@ni/fast-foundation';
import type { FoundationElementTemplate } from '@ni/fast-foundation';
import type { ChatMessageOutbound } from '.';

export const template: FoundationElementTemplate<
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import { html, ViewTemplate } from '@ni/fast-element';
import {
type FoundationElementTemplate
} from '@ni/fast-foundation';
import type { FoundationElementTemplate } from '@ni/fast-foundation';
import type { ChatMessageSystem } from '.';

export const template: FoundationElementTemplate<
Expand Down