Add spright custom colored icons for calendar work item types#2861
Add spright custom colored icons for calendar work item types#2861vivinkrishna-ni wants to merge 38 commits intomainfrom
Conversation
…tps://github.com/ni/nimble into users/vivin/add-missing-base-colors-for-calendar
…tps://github.com/ni/nimble into users/vivin/add-missing-base-colors-for-calendar
…users/vivin/add-more-calendar-theme-aware-tokens
…users/vivin/add-more-calendar-theme-aware-tokens
…tps://github.com/ni/nimble into users/vivin/add-more-calendar-theme-aware-tokens
…users/vivin/add-colored-icons
Dependency ReviewThe following issues were found:
|
…users/vivin/add-colored-icons
| @@ -0,0 +1,5 @@ | |||
| export { IconCalendarCalibration, iconCalendarCalibrationTag } from './calendar-calibration'; | |||
There was a problem hiding this comment.
For symmetry with nimble can you call this file all-icons.ts instead of index.ts?
| import './icons/calendar-calibration'; | ||
| import './icons/calendar-maintenance'; | ||
| import './icons/calendar-reservation'; | ||
| import './icons/calendar-test-plan'; | ||
| import './icons/calendar-transport-order'; |
There was a problem hiding this comment.
After the other rename can just do:
| import './icons/calendar-calibration'; | |
| import './icons/calendar-maintenance'; | |
| import './icons/calendar-reservation'; | |
| import './icons/calendar-test-plan'; | |
| import './icons/calendar-transport-order'; | |
| import './icons/all-icons'; |
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
Doens't look like any nimble-components changes are in this PR, can remove this change file
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
Are you planning to make spright-angular directives for the icons? Could be in a follow-up or in this PR
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
I'm sure you're aware but in case you forgot: you'll need to do framework integration work for these components since you can't rely on the code generation approach we use for core Nimble icons. If you only need Angular it's ok to stop there, but Blazor and React integration are appreciated. This can happen in a follow up PR.
Pull Request
🤨 Rationale
Nimble icons currently do not have a way to change colors based on the requirements, especially when used within Nimble table components. While Nimble provides color override mechanisms, these cannot be applied when icons are used in table cells through the mapping-icon component.
This is a application-specific requirement, so utilizing the
Sprightto register the icons for different types of work items.👩💻 Implementation
IconSvgfor Nimble table compatibilitynimble-tokensto reuse existing assets🧪 Testing
Verified from the storybook build.
✅ Checklist