feat: Add Notification Client#195
Merged
ShriramS-Emerson merged 37 commits intoni:masterfrom Feb 2, 2026
Merged
Conversation
…h-Raja/nisystemlink-clients-python into notification-client
Notification Client - Apply Dynamic Strategy
IN2026-Rohith-Raja
requested review from
cameronwaterman,
rbell517 and
spanglerco
as code owners
SSadaiyappan-NI
approved these changes
Jan 28, 2026
rbell517
requested changes
Jan 28, 2026
nisystemlink/clients/notification/models/_dynamic_notification_configuration.py
Show resolved
Hide resolved
nisystemlink/clients/notification/models/_dynamic_notification_strategy.py
Outdated
Show resolved
Hide resolved
…h-Raja/nisystemlink-clients-python into notification-client
rbell517
requested changes
Jan 29, 2026
nisystemlink/clients/notification/models/_dynamic_notification_configuration.py
Outdated
Show resolved
Hide resolved
nisystemlink/clients/notification/models/_dynamic_notification_configuration.py
Outdated
Show resolved
Hide resolved
nisystemlink/clients/notification/models/_smtp_address_group.py
Outdated
Show resolved
Hide resolved
SSadaiyappan-NI
approved these changes
Jan 30, 2026
nisystemlink/clients/notification/models/_base_notification_metadata.py
Outdated
Show resolved
Hide resolved
rbell517
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notification Client - Apply Dynamic Strategy
What does this Pull Request accomplish?
Created Notification Client implementation for the API
/ninotification/v1/apply-dynamic-strategy. This includes various models required for the request body and performed various tests.What testing has been done?
Used pytest to test the client working. Includes tests that covers negative cases like invalid configurations, invalid recipient address, invalid message template and other cases.