refactor: Update address field key names for Notification client

examples/notification/notification.py

@@ -85,7 +85,7 @@ def create_notification_request_for_alarm(
 retrieved_alarm = alarm_client.get_alarm(instance_id=id)
 
 # Define recipients to notify
-recipients = SmtpAddressFields(toAddresses=["sample1@example.com"])
+recipients = SmtpAddressFields(to_addresses=["sample1@example.com"])
 
 # Create address group
 address_group = SmtpAddressGroup(

nisystemlink/clients/notification/models/_smtp_address_group.py

@@ -10,13 +10,13 @@
 class SmtpAddressFields(JsonModel):
     """Recipient address fields used in SMTP messaging."""
 
-    toAddresses: List[str] | None = None
+    to_addresses: List[str] | None = None
     """List of primary recipient addresses."""
 
-    ccAddresses: List[str] | None = None
+    cc_addresses: List[str] | None = None
     """List of carbon copy recipient addresses."""
 
-    bccAddresses: List[str] | None = None
+    bcc_addresses: List[str] | None = None
     """List of blind carbon copy recipient addresses."""
 
 
@@ -30,15 +30,15 @@ class SmtpAddressGroup(BaseNotificationMetadata):
     """Recipient address fields used for SMTP notifications.
 
     Valid fields:
-        - toAddresses
-        - ccAddresses
-        - bccAddresses
+        - to_addresses
+        - cc_addresses
+        - bcc_addresses
 
     Example:
         {
-            toAddresses: [ "address1@example.com" ],
-            ccAddresses: [ "address2@example.com" ],
-            bccAddresses: [ "address3@example.com" ]
+            to_addresses: [ "address1@example.com" ],
+            cc_addresses: [ "address2@example.com" ],
+            bcc_addresses: [ "address3@example.com" ]
         }
     """
 

tests/integration/notification/test_notification_client.py

@@ -25,9 +25,9 @@ def _smtp_address_group():
         display_name="name",
         properties={"property": "value"},
         fields=SmtpAddressFields(
-            toAddresses=["address1@example.com"],
-            ccAddresses=["address2@example.com"],
-            bccAddresses=["address3@example.com"],
+            to_addresses=["address1@example.com"],
+            cc_addresses=["address2@example.com"],
+            bcc_addresses=["address3@example.com"],
         ),
         referencing_notification_strategies=["reference_notification_strategy"],
     )
@@ -109,7 +109,7 @@ def test__apply_dynamic_strategy_with_invalid_recipient_for_smtp_service__raises
         _smtp_message_template: SmtpMessageTemplate,
     ):
         address_group = SmtpAddressGroup(
-            fields=SmtpAddressFields(toAddresses=["invalid-email"]),
+            fields=SmtpAddressFields(to_addresses=["invalid-email"]),
         )
 
         request_model = DynamicStrategyRequest(
@@ -168,7 +168,7 @@ def test__create_address_group_with_invalid_interpreting_service_name__raises_ex
         with pytest.raises(ValidationError):
             SmtpAddressGroup(
                 interpreting_service_name="invalid_service",
-                fields=SmtpAddressFields(toAddresses=["address1@example.com"]),
+                fields=SmtpAddressFields(to_addresses=["address1@example.com"]),
             )
 
     @responses.activate