feat: Add pandas utility for dataframe#84
Conversation
ancy-augustin
requested review from
cameronwaterman,
mure and
spanglerco
as code owners
| index_name: str = None | ||
| if index: | ||
| index_name = _get_table_index_name(client=client, table_id=table_id) | ||
| if query.columns: |
There was a problem hiding this comment.
Can we combine these two if statements into a single if.
There was a problem hiding this comment.
We cannot combine the if statements because the index_name is required regardless of whether query.columns is None, and checking index_name in query.columns should only occur when both are valid.
|
It would be nice to have a function There is of course challenge in batching the rows upload if the data is large. |
nisystemlink/clients/dataframe/utilities/_pandas_dataframe_operations.py
Outdated
Show resolved
Hide resolved
nisystemlink/clients/dataframe/utilities/_pandas_dataframe_operations.py
Show resolved
Hide resolved
| """The names and order of the columns included in the data frame.""" | ||
|
|
||
| data: List[List[Optional[str]]] | ||
| data: Optional[List[List[Optional[str]]]] = None |
There was a problem hiding this comment.
Could making this field optional lead to an error? This will provide a way to call the API without providing data.
| client (DataFrameClient): Instance of DataFrameClient. | ||
| df (pd.DataFrame): Pandas dataframe. | ||
| table_name (str): Name of the table. | ||
| nullable_columns (bool): Make the columns nullable. Nullable columns can contain `null` values. |
There was a problem hiding this comment.
Can we have a default value to nullable_columns field?
@santhoshramaraj What do you think?
There was a problem hiding this comment.
We need to understand the impact of nullable_columns on performance to choose the default value or require the user to make a conscious decision.
3 participants
What does this Pull Request accomplish?
Adds utility functions to interact with SystemLink
DataFrameAPI using pandas data frames.Why should this Pull Request be merged?
Simplifies working with pandas data frames and SystemLink
DataFrameby providing convenient methods for creating, appending, and querying tables directly from pandas.What testing has been done?
TODO: Detail what testing has been done to ensure this submission meets requirements.