Skip to content

use generic for node value#333

Merged
localheinz merged 1 commit intonicmart:masterfrom
smoench:generic-value
Nov 25, 2025
Merged

use generic for node value#333
localheinz merged 1 commit intonicmart:masterfrom
smoench:generic-value

Conversation

@smoench
Copy link
Contributor

@smoench smoench commented Nov 22, 2024

This pull request

  • Adds template/generic phpdocs for node value

@smoench smoench marked this pull request as ready for review November 22, 2024 13:09
@localheinz localheinz self-assigned this Nov 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (4ca8dd4) to head (c45d4ff).
⚠️ Report is 214 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #333   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        57        57           
===========================================
  Files              6         6           
  Lines            157       154    -3     
===========================================
- Hits             157       154    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@smoench smoench force-pushed the generic-value branch 2 times, most recently from 3bf0846 to 9f1edd2 Compare December 10, 2024 15:35
@localheinz localheinz force-pushed the generic-value branch 3 times, most recently from 6bc42fe to 0866370 Compare November 25, 2025 08:47
@localheinz localheinz self-requested a review November 25, 2025 08:47
@localheinz localheinz merged commit 2def933 into nicmart:master Nov 25, 2025
11 checks passed
@localheinz
Copy link
Collaborator

Thank you, @smoench!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments