Prevent clicking on flags from revealing#12
Open
noloerino wants to merge 1 commit intonicolaschan:masterfrom
Open
Prevent clicking on flags from revealing#12noloerino wants to merge 1 commit intonicolaschan:masterfrom
noloerino wants to merge 1 commit intonicolaschan:masterfrom
Conversation
Owner
|
Could we just change the client side reveal logic? Or is there some reason (e.g., consistency) that the server needs to keep track of this? |
Author
|
I earlier tried adding an extra check on |
Owner
|
Ah I see. This is just the initial board that is sent. It doesn't look like the actual state is kept anywhere in except in the CSS and text property of the square. I guess a sketchy way to do this would be to inspect the HTML element of the square and see if that is a flag. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the user clicks on a flagged square, tiles are no longer revealed. If a flagged square is a zero and would get revealed by an adjacent zero being revealed (but not by a user clicking on it), the flag is still overwritten.