A number of customizations of django-helpdesk by cworth-gh · Pull Request #1 · nimbis/django-helpdesk

cworth-gh · 2017-01-13T19:37:46Z

The first several of these (those with "merge commits") are likely suitable for upstream.

The last few commits are for things that just Nimbis wants, (like dropping the priority and due-date fields). We should perhaps figure out a way to do those outside of django-helpdesk (such as in overridden templates) or submit a more general fix upstream to allow us to configure the behavior we want. But for now, we can carry this fork.

This is in support of this card: https://trello.com/c/w37C53RJ/1185-tss-add-django-helpdesk-app

cworth-gh · 2017-01-13T20:35:15Z

TSS: Add django-helpdesk app.

shaunbrady · 2017-01-19T16:43:39Z

helpdesk/templates/helpdesk/public_homepage.html

 <fieldset>
    <div class="form-group {% if field.errors %}has-error{% endif %}">
-        <label for='id_ticket'>{% trans "Ticket" %}</label>
+        <label for='id_ticket'>{% trans "Ticket number" %}</label>


Nitpick: s/number/Number/ ? I need to see this, so maybe it makes visual sense.

Thanks. Fixed.

shaunbrady · 2017-01-19T17:51:13Z

helpdesk/models.py

-            site = Site(domain='configure-django-sites.com')
-        return u"http://%s%s?ticket=%s&email=%s" % (
-            site.domain,
+        return self._absolute_uri(u"%s?ticket=%s&email=%s" % (


We're (you and I) are literally have a conversion right now about minimal changes, but if it should so interest you, you might make this cleaner with .format( (using args or kwargs) ). Dealers choice.

I actually considered that. But there are a bunch of cases of '%'-style formatting here.

What we'll probably want to do is to fix all of those in a standalone commit which we can send upstream.

Let's let our usage of this app. cook for a bit, and if we don't decide to throw it away, then we can do a bunch of cleanups targeting upstream.

shaunbrady · 2017-01-19T17:52:20Z

One or two small comments. Code looks good, especially considering some of the oddities of the upstream we discussed.

ericamador · 2017-01-24T18:38:01Z

helpdesk/views/public.py

+    # If there is no email address in the query string, get it from
+    # the currently logged-in user
+    if email == '':
+        email = request.user.email


This has the effect of raising AttributeError: 'AnonymousUser' object has no attribute 'email' if a user attempts to view a ticket while not authenticated.

Yes. Better would be a redirect to a login page. I think I'd like to punt on this for now, (since we have two cards for doing the CMS integration and for fixing several similar issues related to permissions). I think one or both of those cards will end up addressing this.

Updated get_email tests

`get_email` management command: Force message to unicode to avoid encoding issues

Would create a 500 when user omitted their email. Only a partial improve. Added a TODO: as this view still breaks if passing non-numeric characters to the ID. I assume this needs a full overhaul really.

Never return None from views.public.create_ticket

…in followup comments

…using MySQL with UTF-8 collation

…uture correspondence, set to view only initially, and update tests for CC

…ilities (with and without a CC)

…r and fix django-helpdesk#72 in future changes

…plicates), add testing for it

… ticket if necessary and not already the assignee, etc.

This is to make it easier to see what is being imported by this file.

This is dead code that is never used anywhere.

This is done for style purposes.

This commit fixes the line lengths in models.py to comply with flake8.

Previously, the code would first try to build a URL using the request object if one was available. However, the "if self.request" was often raising an uncaught AttributeError because the request didn't exist. We address this problem by simply always using the current Site to build the URL. This has the added benefit of reducing the cyclomatic complexity of this function, making the behavior easier to reason about and maintain.

This will make the need to ensure that a Django Site object exists much more obvious.

Fix helpdesk email links

This will display the closed helpdesk tickets to staff users. Previously users could only find these tickets if the ticket was assigned to them.

Show closed tickets

"Owned by me" tickets will now filter based on all django-allauth EmailAddress objects associated with the user the filed the ticket, instead of just email address associated with the ticket.

Fix email filtering

All emails sent by helpdesk will no longer contain attachments. This is done to prevent the leaking of potentially sensitive information. Note that the ability to send attachments remains untouched but we are just removing all the current uses of that feature.

Remove attachments from all sent emails

Todd changed the email he was using on his account. Since django-helpdesk associates tickets to email addresses directly, he lost access to all of his old tickets. This management command has been written to solve any other cases like this, where a user switches from an old email to a new one.

Implement management command to update email addresses on tickets.

When tickets are updated or marked as 'Resolved', the email which is sent to the user contains text instructing the users to reply to the email if they need to provide additional information when tickets are updated, or if they feel the resolution is not adequate. In this commit, we remove that text from the email template, and instead instruct users to re-open the ticket if the resolution is not adequate, or view the ticket online to provide additional information.

Remove reply to email text from email template

When new tickets are created, the courtesy email informing users their tickets have been received previously contained a line informing users to reply to the email using the ticket number in the subject. In this commit, that line is removed from the email. Instead, users are given a link to the ticket on the site and asked to use that to provide further information or view any updates.

This version of django-helpdesk removes text informing users to reply to the email when users submit new tickets. https://trello.com/c/ytuM4uIK

…il-text Remove respond to email text when submitting new tickets. https://trello.com/c/ytuM4uIK

The urlresolvers module no longer exists in Django 2.2.

This includes fixes necessary for Django 2.2 compatibility.

cworth-gh force-pushed the master branch from 0ec2f4b to 978d365 Compare January 13, 2017 19:54

shaunbrady reviewed Jan 19, 2017

View reviewed changes

ericamador reviewed Jan 24, 2017

View reviewed changes

cworth-gh force-pushed the master branch 3 times, most recently from cc7e80f to 81090f0 Compare January 27, 2017 09:23

reduxionist and others added 21 commits April 6, 2017 07:59

Update comments for consistency with their targets

b87a30c

Merge pull request django-helpdesk#501 from gwasser/487_new_test

b94795b

Updated get_email tests

Merge branch 'master' into master

d843a21

Merge pull request django-helpdesk#487 from mikhuang/master

c8935ee

`get_email` management command: Force message to unicode to avoid encoding issues

Never return None from views.public.create_ticket

b7a9718

Would create a 500 when user omitted their email. Only a partial improve. Added a TODO: as this view still breaks if passing non-numeric characters to the ID. I assume this needs a full overhaul really.

Don't show error on initial get.

fb07822

Merge pull request django-helpdesk#506 from willstott101/patch-1

bb59de0

Never return None from views.public.create_ticket

django-helpdesk#72: Prevent django template tags from being executed …

01e87f2

…in followup comments

django-helpdesk#184: provide more explicit install documentation for …

03b5e41

…using MySQL with UTF-8 collation

django-helpdesk#95: save CC'd emails on a comment to the Ticket for f…

b2ac1fd

…uture correspondence, set to view only initially, and update tests for CC

Add Django 1.11 to testing on Travis CI

93934fe

PEP8 fixups

49aac65

Separate out the CC test from plain test so we're testing both possib…

7b84265

…ilities (with and without a CC)

Fix encoding first before splitting strings, so it works on Python 2

8e1a6b3

Add test with django template tag in email body, to ensure we test fo…

e3a3786

…r and fix django-helpdesk#72 in future changes

PEP8 fixes for too many blank lines

3b22bb6

Only add CC emails to Ticket if they were not already included (no du…

34ce553

…plicates), add testing for it

Check number of CCs to ensure no duplicates made it through

220c046

Prevent adding Users or Queue email to the CC list

8963fa6

Check CC'd email against list of User emails, and add the User to the…

bf344b0

… ticket if necessary and not already the assignee, etc.

PEP-8 fixes

47f3eb8

ericamador and others added 30 commits May 24, 2018 16:29

Pull all imports to top of lib.py

26fc078

This is to make it easier to see what is being imported by this file.

Remove references to text_is_spam function

908fcdd

This is dead code that is never used anywhere.

Fix line lengths in lib.py to comply with flake8

4afefe6

This is done for style purposes.

Fix long lines in models.py

3e55994

This commit fixes the line lengths in models.py to comply with flake8.

Update CHANGES and setup.py for new release v0.2.6+nimbis.15

a17a483

Make URL generation raise exception rather than use default Site

f2475a1

This will make the need to ensure that a Django Site object exists much more obvious.

Merge pull request #15 from nimbis/fix-helpdesk-email-links

717a163

Fix helpdesk email links

Display closed helpdesk tickets

d58078d

This will display the closed helpdesk tickets to staff users. Previously users could only find these tickets if the ticket was assigned to them.

Update CHANGES and setup.py for new release v0.2.6+nimbis.16

41a2a5c

Merge pull request #16 from nimbis/show-closed-tickets

47f76ec

Show closed tickets

Filter "Owned by me" tickets based on all django-allauth EmailAddresses

bc5a362

"Owned by me" tickets will now filter based on all django-allauth EmailAddress objects associated with the user the filed the ticket, instead of just email address associated with the ticket.

Update CHANGES and setup.py for new release v0.2.6+nimbis.17

bce49f7

Merge pull request #19 from nimbis/fix-email-filtering

0bb10ad

Fix email filtering

Update CHANGES and setup.py for new release.

dff8180

Merge pull request #18 from nimbis/remove-email-attachments

eee19c1

Remove attachments from all sent emails

Merge pull request #20 from nimbis/new-email-ticket-command

a59989f

Implement management command to update email addresses on tickets.

Update CHANGES and setup.py for new release.

f3ca7e7

Replace broken login redirect with 404.

860db38

Update CHANGES and setup.py for bumping to 0.2.6+nimbis.20

b124562

Update CHANGES and setup.py for release 0.2.6+nimbis.21.

1316037

Merge pull request #22 from nimbis/remove-reply-to-email-text

92181c5

Remove reply to email text from email template

Update CHANGES and setup.py for release 0.2.6+nimbis.22.

0bde272

This version of django-helpdesk removes text informing users to reply to the email when users submit new tickets. https://trello.com/c/ytuM4uIK

Merge pull request #23 from nimbis/site-bug-fix/remove-respond-to-ema…

40adcc5

…il-text Remove respond to email text when submitting new tickets. https://trello.com/c/ytuM4uIK

Fix bugs preventing Django 2.2 updates.

8d4f0c3

The urlresolvers module no longer exists in Django 2.2.

Bump version in preparation for imminent release.

a59ec76

This includes fixes necessary for Django 2.2 compatibility.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

A number of customizations of django-helpdesk#1

A number of customizations of django-helpdesk#1
cworth-gh wants to merge 327 commits intoupstream-masterfrom
master

cworth-gh commented Jan 13, 2017

Uh oh!

cworth-gh commented Jan 13, 2017

Uh oh!

shaunbrady Jan 19, 2017

Uh oh!

cworth-gh Jan 26, 2017

Uh oh!

shaunbrady Jan 19, 2017

Uh oh!

cworth-gh Jan 26, 2017

Uh oh!

shaunbrady commented Jan 19, 2017

Uh oh!

ericamador Jan 24, 2017

Uh oh!

cworth-gh Jan 26, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

Comments

Conversation

cworth-gh commented Jan 13, 2017

Uh oh!

cworth-gh commented Jan 13, 2017

Uh oh!

shaunbrady Jan 19, 2017

Choose a reason for hiding this comment

Uh oh!

cworth-gh Jan 26, 2017

Choose a reason for hiding this comment

Uh oh!

shaunbrady Jan 19, 2017

Choose a reason for hiding this comment

Uh oh!

cworth-gh Jan 26, 2017

Choose a reason for hiding this comment

Uh oh!

shaunbrady commented Jan 19, 2017

Uh oh!

ericamador Jan 24, 2017

Choose a reason for hiding this comment

Uh oh!

cworth-gh Jan 26, 2017

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants