[#18] [API] As a user, I can register an account, [#17] [API] As a user, I can login#46
Open
mosharaf13 wants to merge 4 commits intodevelopfrom
Open
[#18] [API] As a user, I can register an account, [#17] [API] As a user, I can login#46mosharaf13 wants to merge 4 commits intodevelopfrom
mosharaf13 wants to merge 4 commits intodevelopfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| # frozen_string_literal: true | ||
|
|
||
| module Api | ||
| module V1 |
| # frozen_string_literal: true | ||
|
|
||
| module Api | ||
| module V1 |
| class UsersController < ApplicationController | ||
| skip_before_action :doorkeeper_authorize!, only: %i[create] | ||
|
|
||
| def create |
There was a problem hiding this comment.
| Has approx 6 statements |
| render(json: { user: user_data }) | ||
| end | ||
|
|
||
| def build_user_data(user, access_token) |
There was a problem hiding this comment.
| Doesn't depend on instance state (maybe move it to another class?) |
| # todo extract it inside authenticable | ||
| def self.authenticate(email, password) | ||
| user = User.find_for_authentication(email: email) | ||
| user&.valid_password?(password) ? user : nil |
There was a problem hiding this comment.
| Is controlled by argument 'password' |
|
Code coverage is now at 0.00% (0/165 lines) Generated by 🚫 Danger |
sanG-github
requested changes
Jun 20, 2023
Collaborator
sanG-github
left a comment
sanG-github
left a comment
There was a problem hiding this comment.
Just curiosity about Closes #17 in the description.
Contributor
Author
Login is also done in this PR 😀. |
Co-authored-by: Sang Huynh Thanh <63148598+sanG-github@users.noreply.github.com>
mosharaf13
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18
Closes #17
What happened 👀
Insight 📝
Proof Of Work 📹
Successful Registration
Duplicate Email
Invalid Password
Invalid client id
Login